Merge lp:~pkunal-parmar/ubuntu-calendar-app/WeekView-Scrolling into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Kunal Parmar
Approved revision: 715
Merged at revision: 731
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/WeekView-Scrolling
Merge into: lp:ubuntu-calendar-app
Diff against target: 60 lines (+26/-3)
3 files modified
EventBubble.qml (+2/-2)
PathViewBase.qml (+17/-0)
TimeLineBaseComponent.qml (+7/-1)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/WeekView-Scrolling
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+269564@code.launchpad.net

Commit message

Changed week view scrolling to resolve Bug #1473682

Description of the change

Changed week view scrolling to resolve Bug #1473682

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

Seems like some jenkins issue "jenkins job parameter [use_description_for_commit]: not found"

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

LGTM!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/calendar-app-autolanding/3/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/137/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Looks like a simple merge conflict.

715. By Kunal Parmar

merge from trunk

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'EventBubble.qml'
2--- EventBubble.qml 2015-05-08 02:03:36 +0000
3+++ EventBubble.qml 2015-11-29 03:17:46 +0000
4@@ -221,8 +221,8 @@
5 anchors.fill: parent
6 drag.target: isLiveEditing ? infoBubble : null
7 drag.axis: Drag.YAxis
8- drag.minimumY: flickable === null? 0: flickable.y
9- drag.maximumY: flickable === null? 0 :flickable.contentHeight - infoBubble.height
10+ drag.minimumY: flickable ? flickable.y : 0
11+ drag.maximumY: flickable ? flickable.contentHeight - infoBubble.height : infoBubble.height
12 onReleased: parent.Drag.drop()
13 onClicked: {
14 if( isLiveEditing ) {
15
16=== modified file 'PathViewBase.qml'
17--- PathViewBase.qml 2014-09-20 10:45:35 +0000
18+++ PathViewBase.qml 2015-11-29 03:17:46 +0000
19@@ -51,6 +51,23 @@
20 return 1;
21 }
22
23+ function swipeDirection() {
24+
25+ if( intern.previousIndex == 0 && currentIndex == count - 1) {
26+ return -1;
27+ }
28+
29+ if( intern.previousIndex == count-1 && currentIndex == 0) {
30+ return 1;
31+ }
32+
33+ if(currentIndex > intern.previousIndex ){
34+ return 1;
35+ } else {
36+ return -1;
37+ }
38+ }
39+
40 Keys.onLeftPressed:{
41 root.decrementCurrentIndex();
42 }
43
44=== modified file 'TimeLineBaseComponent.qml'
45--- TimeLineBaseComponent.qml 2015-09-05 05:30:23 +0000
46+++ TimeLineBaseComponent.qml 2015-11-29 03:17:46 +0000
47@@ -74,7 +74,13 @@
48 timeLineView.contentX = timeLineView.contentWidth - timeLineView.width
49 }
50 } else {
51- timeLineView.contentX = 0;
52+ //need to check swipe direction
53+ //and change startion position as per direction
54+ if(weekViewPath.swipeDirection() === -1) {
55+ timeLineView.contentX = timeLineView.contentWidth - timeLineView.width
56+ } else {
57+ timeLineView.contentX = 0;
58+ }
59 }
60 }
61

Subscribers

People subscribed via source and target branches

to status/vote changes: