Merge lp:~pkunal-parmar/ubuntu-calendar-app/Parallax-EventBubble into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 221
Merged at revision: 222
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/Parallax-EventBubble
Merge into: lp:ubuntu-calendar-app
Diff against target: 66 lines (+34/-0)
2 files modified
EventBubble.qml (+33/-0)
TimeLineBaseComponent.qml (+1/-0)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/Parallax-EventBubble
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+212858@code.launchpad.net

Commit message

fixes Bug #1294681

Added parallax effect in case of long event

Description of the change

fixes Bug #1294681

Added parallax effect in case of long event

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good , and working perfectly.

Thank you Kunal.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'EventBubble.qml'
2--- EventBubble.qml 2014-03-22 03:56:27 +0000
3+++ EventBubble.qml 2014-03-26 14:32:35 +0000
4@@ -10,6 +10,8 @@
5 property int wideType: 1;
6 property int narrowType: 2;
7
8+ property Flickable flickable;
9+
10 readonly property int minimumHeight: timeLabel.height
11
12 signal clicked(var event);
13@@ -68,10 +70,41 @@
14 if( event.displayLabel)
15 timeLabel.text = event.displayLabel;
16 }
17+
18+ layoutBubbleDetails();
19+ }
20+
21+ function layoutBubbleDetails() {
22+ if(!flickable || flickable === undefined ) {
23+ return;
24+ }
25+
26+ if( infoBubble.y < flickable.contentY && infoBubble.height > flickable.height) {
27+ var y = (flickable.contentY - infoBubble.y) * 1.2;
28+ if( (y+ detailsColumn.height) > infoBubble.height) {
29+ y = infoBubble.height - detailsColumn.height;
30+ }
31+ detailsColumn.y = y;
32+ }
33+ }
34+
35+ Connections{
36+ target: flickable
37+ onContentYChanged: {
38+ layoutBubbleDetails();
39+ }
40+ }
41+ Connections{
42+ target: detailsColumn
43+ onHeightChanged: {
44+ layoutBubbleDetails();
45+ }
46 }
47
48 Column{
49+ id: detailsColumn
50 width: parent.width
51+
52 Row{
53 width: parent.width
54
55
56=== modified file 'TimeLineBaseComponent.qml'
57--- TimeLineBaseComponent.qml 2014-03-22 04:43:11 +0000
58+++ TimeLineBaseComponent.qml 2014-03-26 14:32:35 +0000
59@@ -95,6 +95,7 @@
60 anchors.right: parent.right
61 anchors.leftMargin: units.gu(0.1)
62 anchors.rightMargin: units.gu(0.1)
63+ flickable: timeLineView
64 clip: true
65 }
66 }

Subscribers

People subscribed via source and target branches

to status/vote changes: