Merge lp:~pkunal-parmar/ubuntu-calendar-app/LongCalName into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 425
Merged at revision: 480
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/LongCalName
Merge into: lp:ubuntu-calendar-app
Diff against target: 24 lines (+2/-1)
2 files modified
CalendarChoicePopup.qml (+1/-0)
NewEvent.qml (+1/-1)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/LongCalName
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+236250@code.launchpad.net

Commit message

Resolves Bug #1364985

Description of the change

Resolves Bug #1364985

Calendar name list in Calendar View needs to be ellided or support multi line

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me!!
Thanks kunal for MR.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CalendarChoicePopup.qml'
2--- CalendarChoicePopup.qml 2014-09-20 20:16:46 +0000
3+++ CalendarChoicePopup.qml 2014-09-28 11:56:21 +0000
4@@ -85,6 +85,7 @@
5 elide: Text.ElideRight
6 opacity: checkBox.checked ? 1.0 : 0.8
7 color: UbuntuColors.midAubergine
8+ width: parent.width - calendarColorCode.width - checkBox.width - units.gu(6) /*margins*/
9 anchors {
10 left: calendarColorCode.right
11 margins: units.gu(2)
12
13=== modified file 'NewEvent.qml'
14--- NewEvent.qml 2014-09-24 11:31:57 +0000
15+++ NewEvent.qml 2014-09-28 11:56:21 +0000
16@@ -508,7 +508,7 @@
17 model: root.model.getCollections();
18
19 delegate: OptionSelectorDelegate{
20- text: modelData.name
21+ text: modelData.name
22
23 UbuntuShape{
24 id: calColor

Subscribers

People subscribed via source and target branches

to status/vote changes: