Merge lp:~pkunal-parmar/ubuntu-calendar-app/Hide_Allday into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 291
Merged at revision: 291
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/Hide_Allday
Merge into: lp:ubuntu-calendar-app
Diff against target: 11 lines (+1/-0)
1 file modified
EventDetails.qml (+1/-0)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/Hide_Allday
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+221067@code.launchpad.net

Commit message

Hiding All day event checkbox in case of non-allday event, as per design team's feedback

Description of the change

Hiding All day event checkbox in case of non-allday event, as per design team's feedback

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Hi Kunal,
This looks good to me.
Thank you

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'EventDetails.qml'
2--- EventDetails.qml 2014-05-23 07:21:51 +0000
3+++ EventDetails.qml 2014-05-27 11:33:18 +0000
4@@ -256,6 +256,7 @@
5 width: parent.width
6 spacing: units.gu(1)
7 anchors.margins: units.gu(0.5)
8+ visible: allDayEventCheckbox.checked
9
10 Label {
11 text: i18n.tr("All Day event:")

Subscribers

People subscribed via source and target branches

to status/vote changes: