Merge lp:~pkunal-parmar/ubuntu-calendar-app/HideTime_AllDayEvent into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 275
Merged at revision: 275
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/HideTime_AllDayEvent
Merge into: lp:ubuntu-calendar-app
Diff against target: 20 lines (+5/-2)
1 file modified
EventDetails.qml (+5/-2)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/HideTime_AllDayEvent
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+220081@code.launchpad.net

Commit message

Hiding time in case of Allday event

Description of the change

Hiding time in case of Allday event

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me Kunal!!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'EventDetails.qml'
2--- EventDetails.qml 2014-05-15 06:39:54 +0000
3+++ EventDetails.qml 2014-05-19 15:10:22 +0000
4@@ -114,11 +114,14 @@
5 requestId = model.fetchItems([e.parentId]);
6 }
7
8+ allDayEventCheckbox.checked = e.allDay;
9+
10+ startHeader.visible = !e.allDay;
11+ endHeader.visible = !e.allDay;
12+
13 startHeader.value = startTime;
14 endHeader.value = endTime;
15
16- allDayEventCheckbox.checked = e.allDay;
17-
18 // This is the event title
19 if( e.displayLabel) {
20 titleLabel.text = e.displayLabel;

Subscribers

People subscribed via source and target branches

to status/vote changes: