Merge lp:~pkunal-parmar/ubuntu-calendar-app/FixMultiEvent into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 320
Merged at revision: 321
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/FixMultiEvent
Merge into: lp:ubuntu-calendar-app
Diff against target: 14 lines (+0/-4)
1 file modified
TimeLineBaseComponent.qml (+0/-4)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/FixMultiEvent
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+223076@code.launchpad.net

Commit message

Removing anchors usage as now TimeLineView decides width and position of event based on layout algorithm

Description of the change

Removing anchors usage as now TimeLineView decides width and position of event based on layout algorithm

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me. Thanks kunal

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'TimeLineBaseComponent.qml'
2--- TimeLineBaseComponent.qml 2014-06-10 12:28:31 +0000
3+++ TimeLineBaseComponent.qml 2014-06-13 13:57:34 +0000
4@@ -143,10 +143,6 @@
5 id: comp
6 EventBubble {
7 type: root.type == ViewType.ViewTypeWeek ? narrowType : wideType
8-
9- anchors{
10- left: parent.left; right: parent.right
11- }
12 flickable: root.isActive ? timeLineView : null
13 clip: true
14 }

Subscribers

People subscribed via source and target branches

to status/vote changes: