Merge lp:~pkunal-parmar/ubuntu-calendar-app/DefView into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 719
Merged at revision: 719
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/DefView
Merge into: lp:ubuntu-calendar-app
Diff against target: 37 lines (+8/-2)
1 file modified
calendar.qml (+8/-2)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/DefView
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Jenkins Bot continuous-integration Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+274062@code.launchpad.net

Commit message

Resolves Bug #1494394

Description of the change

Resolves Bug #1494394

To post a comment you must log in.
719. By Kunal Parmar

comment code removed

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Let me know if you have further troubles. I'll be fixing the messages jenkins leaves to be a bit saner.

Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Nice one! Works well.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'calendar.qml'
2--- calendar.qml 2015-09-05 05:30:23 +0000
3+++ calendar.qml 2015-10-11 02:22:53 +0000
4@@ -19,6 +19,7 @@
5 import Ubuntu.Components 1.1
6 import Ubuntu.Components.Popups 1.0
7 import QtOrganizer 5.0
8+import Qt.labs.settings 1.0
9
10 import "dateExt.js" as DateExt
11
12@@ -308,11 +309,11 @@
13 else {
14 // Due to bug #1231558 {if (args.defaultArgument.at(0))} is always true
15 // After the fix we can delete this else
16- tabs.selectedTabIndex = weekTab.index;
17+ tabs.selectedTabIndex = settings.defaultViewIndex;
18 }
19 } // End of if about args.values
20 else {
21- tabs.selectedTabIndex = weekTab.index;
22+ tabs.selectedTabIndex = settings.defaultViewIndex;
23 }
24 } // End of Component.onCompleted:
25
26@@ -320,6 +321,11 @@
27 id: commonHeaderActions
28 }
29
30+ Settings {
31+ id: settings
32+ property alias defaultViewIndex: tabs.selectedTabIndex
33+ }
34+
35 Keys.onTabPressed: {
36 if( event.modifiers & Qt.ControlModifier) {
37 var currentTab = tabs.selectedTabIndex;

Subscribers

People subscribed via source and target branches

to status/vote changes: