Merge lp:~pkunal-parmar/ubuntu-calendar-app/1240810_yearoverflow into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 159
Merged at revision: 171
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/1240810_yearoverflow
Merge into: lp:ubuntu-calendar-app
Diff against target: 24 lines (+2/-1)
2 files modified
MonthComponent.qml (+1/-0)
YearView.qml (+1/-1)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/1240810_yearoverflow
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Riccardo Padovani (community) Approve
Ubuntu Calendar Developers Pending
Review via email: mp+191642@code.launchpad.net

Commit message

bug#1240810 fixed

Description of the change

bug#1240810, fixed

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Good work Kunal, now year view it's ok!

review: Approve
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

HI Riccardo, Thanks for review, If code change is fine than can you change MR's Status to Approved as well ?

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
158. By Kunal Parmar

Merge from trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
159. By Kunal Parmar

Merge from trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MonthComponent.qml'
2--- MonthComponent.qml 2013-10-22 17:32:19 +0000
3+++ MonthComponent.qml 2013-11-27 23:13:57 +0000
4@@ -32,6 +32,7 @@
5
6 anchors.top: parent.top
7 anchors.topMargin: units.gu(1.5)
8+ anchors.bottomMargin: units.gu(1)
9 anchors.fill: parent
10 spacing: units.gu(1.5)
11
12
13=== modified file 'YearView.qml'
14--- YearView.qml 2013-10-09 10:46:23 +0000
15+++ YearView.qml 2013-11-27 23:13:57 +0000
16@@ -51,7 +51,7 @@
17 anchors.top: parent.top
18
19 cellWidth: width/2
20- cellHeight: cellWidth * 1.2
21+ cellHeight: cellWidth * 1.4
22
23 model: 12 /* months in a year */
24 snapMode: GridView.SnapOneRow

Subscribers

People subscribed via source and target branches

to status/vote changes: