Merge lp:~pkgcrosswire/sword/shell-testsuite into lp:sword/debian

Proposed by Dimitri John Ledkov
Status: Merged
Approved by: Jonathan Marsden
Approved revision: 48
Merged at revision: not available
Proposed branch: lp:~pkgcrosswire/sword/shell-testsuite
Merge into: lp:sword/debian
Diff against target: None lines
To merge this branch: bzr merge lp:~pkgcrosswire/sword/shell-testsuite
Reviewer Review Type Date Requested Status
CrossWire Packaging Team Pending
Review via email: mp+6765@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

This enables shell-testsuite at runtime.

It adds the "old" cppunit test as well, but keeps it commented, because it currently is broken.

Revision history for this message
Jonathan Marsden (jmarsden) wrote :

Let's do it.

Let's also not forget to offer the code diffs to upstream.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-05-25 01:12:22 +0000
3+++ debian/changelog 2009-05-25 01:35:48 +0000
4@@ -37,8 +37,13 @@
5 * debian/libsword8.lintian-overrides: added override for module
6 installation directory.
7 * debian/copyright: Updated with information about everyfile.
8+ * debian/rules:
9+ - enabled shell script based testsuite
10+ - added commented out cppunit testsuite
11+ * debian/patches/40_missing_includes.diff: added missing stdio.h to
12+ prevent FTBS of the testsuite.
13
14- -- Dmitrijs Ledkovs <dmitrij.ledkov@gmail.com> Sat, 23 May 2009 02:18:34 +0000
15+ -- Dmitrijs Ledkovs <dmitrij.ledkov@gmail.com> Mon, 25 May 2009 01:34:57 +0000
16
17 sword (1.5.11-1) experimental; urgency=low
18
19
20=== added file 'debian/patches/40_missing_includes.diff'
21--- debian/patches/40_missing_includes.diff 1970-01-01 00:00:00 +0000
22+++ debian/patches/40_missing_includes.diff 2009-05-25 01:35:48 +0000
23@@ -0,0 +1,49 @@
24+Adding missing <stdio.h> includes in the testsuite.
25+Index: sword-1.6.0/tests/localetest.cpp
26+===================================================================
27+--- sword-1.6.0.orig/tests/localetest.cpp 2009-05-25 01:56:37.000000000 +0100
28++++ sword-1.6.0/tests/localetest.cpp 2009-05-25 02:15:05.000000000 +0100
29+@@ -18,6 +18,7 @@
30+ #include <localemgr.h>
31+ #include <versekey.h>
32+ #include <iostream>
33++#include <stdio.h>
34+ #ifndef NO_SWORD_NAMESPACE
35+ using namespace sword;
36+ #endif
37+Index: sword-1.6.0/tests/parsekey.cpp
38+===================================================================
39+--- sword-1.6.0.orig/tests/parsekey.cpp 2009-05-25 01:56:37.000000000 +0100
40++++ sword-1.6.0/tests/parsekey.cpp 2009-05-25 02:15:05.000000000 +0100
41+@@ -16,6 +16,7 @@
42+ */
43+
44+ #include <iostream>
45++#include <stdio.h>
46+
47+ #include <versekey.h>
48+ #include <localemgr.h>
49+Index: sword-1.6.0/tests/rawldidxtest.cpp
50+===================================================================
51+--- sword-1.6.0.orig/tests/rawldidxtest.cpp 2009-05-25 01:56:37.000000000 +0100
52++++ sword-1.6.0/tests/rawldidxtest.cpp 2009-05-25 02:15:05.000000000 +0100
53+@@ -19,6 +19,7 @@
54+ #include <rawstr.h>
55+ #include <swmgr.h>
56+ #include <filemgr.h>
57++#include <stdio.h>
58+
59+ #ifndef __GNUC__
60+ #include <io.h>
61+Index: sword-1.6.0/tests/filtertest.cpp
62+===================================================================
63+--- sword-1.6.0.orig/tests/filtertest.cpp 2009-05-25 02:15:14.000000000 +0100
64++++ sword-1.6.0/tests/filtertest.cpp 2009-05-25 02:15:27.000000000 +0100
65+@@ -20,6 +20,7 @@
66+ #include <filemgr.h>
67+ #include <papyriplain.h>
68+ #include <utf8utf16.h>
69++#include <stdio.h>
70+ //#include <swmgr.h>
71+ #ifndef NO_SWORD_NAMESPACE
72+ using namespace sword;
73
74=== modified file 'debian/patches/series'
75--- debian/patches/series 2009-04-13 03:22:23 +0000
76+++ debian/patches/series 2009-05-25 01:35:48 +0000
77@@ -1,2 +1,3 @@
78 02_libver.diff
79+40_missing_includes.diff
80
81
82=== modified file 'debian/rules'
83--- debian/rules 2009-05-25 01:12:22 +0000
84+++ debian/rules 2009-05-25 01:33:54 +0000
85@@ -5,17 +5,21 @@
86 include /usr/share/cdbs/1/rules/patchsys-quilt.mk
87
88 DEB_DH_INSTALL_SOURCEDIR := debian/tmp
89-DEB_CONFIGURE_EXTRA_FLAGS := --with-zlib --with-clucene=/usr --with-icu #--enable-debug
90+DEB_CONFIGURE_EXTRA_FLAGS := --with-zlib --with-clucene=/usr --with-icu --enable-tests #--enable-debug
91 DEB_DH_MAKESHLIBS_ARGS_libsword8 := -V"libsword8 (>= 1.6)"
92 DEB_SHLIBDEPS_INCLUDE_libsword8 := debian/tmp/usr/lib
93 DEB_SHLIBDEPS_INCLUDE_diatheke := debian/libsword8/usr/lib
94 #DEB_DBG_PACKAGE_libsword8 := libsword-dbg
95+#CppUnitTestSuite - currently broken
96+#DEB_MAKE_CHECK_TARGET := check
97 #DEB_OPT_FLAG=-g -O0 -Werror
98
99 # The next two rules use chrpath to remove unwanted rpath info
100 # from the compiled binaries when they are built on amd64.
101
102 build/libsword8::
103+ #Running Shell based Testsuite
104+ $(shell cd tests/testsuite && ./runall.sh 1>&2)
105 chrpath -d $(CURDIR)/lib/.libs/libsword.so*
106 chrpath -d $(CURDIR)/utilities/.libs/*
107

Subscribers

People subscribed via source and target branches