Merge ~pjds/snap-store-proxy-charm:main into snap-store-proxy-charm:main

Proposed by Peter Jose De Sousa
Status: Merged
Approved by: Alex Ramanau
Approved revision: 3a70ab9522cede02e8940a4bb1b2296ee419927c
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pjds/snap-store-proxy-charm:main
Merge into: snap-store-proxy-charm:main
Diff against target: 43 lines (+11/-3)
2 files modified
charmcraft.yaml (+9/-2)
metadata.yaml (+2/-1)
Reviewer Review Type Date Requested Status
Alex Ramanau Approve
Milos Approve
Review via email: mp+465968@code.launchpad.net

Commit message

Update the charm to run on 22.04 and 24.04

To post a comment you must log in.
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Beginning pre-merge CI tests for revision 3a70ab9522cede02e8940a4bb1b2296ee419927c

Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :

Pre-merge CI tests failed for revision 3a70ab9522cede02e8940a4bb1b2296ee419927c
Running landing tests failed.
https://jenkins.ols.ps5.canonical.com/job/snap-store-proxy-charm-pre-merge-tests/1/

Revision history for this message
Alex Ramanau (drednout) wrote :

Hi, Peter!

I've just fixed tests and pushed changes to separate MP: https://code.launchpad.net/~drednout/snap-store-proxy-charm/+git/snap-store-proxy-charm/+merge/466222

You should wait until these changes will be merged to main and then rebase your branch against latest upstream main.

Revision history for this message
Milos (miloslu) wrote :

Thanks for this MP! I tested this branch and the charm builds as expected. A rebase might not be necessary because Jenkins will automatically put these commits on top of the main once Alex's MP is merged. Unless there are merge conflicts, which shouldn't be the case.

review: Approve
Revision history for this message
Alex Ramanau (drednout) wrote :

Thanks, Peter! I'll try to merge it and release edge version of charm.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charmcraft.yaml b/charmcraft.yaml
2index c8a34a0..1f2d1cf 100644
3--- a/charmcraft.yaml
4+++ b/charmcraft.yaml
5@@ -9,7 +9,7 @@ type: "charm"
6 bases:
7 - build-on:
8 - name: "ubuntu"
9- channel: "20.04"
10+ channel: "22.04"
11 architectures:
12 - amd64
13 run-on:
14@@ -17,7 +17,14 @@ bases:
15 channel: "20.04"
16 architectures:
17 - amd64
18-
19+ - name: "ubuntu"
20+ channel: "22.04"
21+ architectures:
22+ - amd64
23+ - name: "ubuntu"
24+ channel: "24.04"
25+ architectures:
26+ - amd64
27 parts:
28 charm:
29 charm-binary-python-packages:
30diff --git a/metadata.yaml b/metadata.yaml
31index 3854c53..b522623 100644
32--- a/metadata.yaml
33+++ b/metadata.yaml
34@@ -7,7 +7,8 @@ name: snap-store-proxy
35 description: |
36 Install and manage a snap-store-proxy on premise.
37 summary: |
38- The Snap Store Proxy provides an on-premise edge proxy to the general Snap Store for your devices. Devices are registered with the proxy, and all communication with the Store will flow through the proxy.
39+ The Snap Store Proxy provides an on-premise edge proxy to the general Snap Store for your devices.
40+ Devices are registered with the proxy, and all communication with the Store will flow through the proxy.
41 maintainers:
42 - Wouter van Bommel <wouter.bommel>@canonical.com
43 tags:

Subscribers

People subscribed via source and target branches