~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm:shared-triggers

Branch merges

Propose for merging

Merged into ubuntu-mirror-charm:master at revision 9667b405eac9fc0e223190172d63ea22fc97b1e9

Stuart Bishop (community): Approve on 2020-08-03

Haw Loeung: Approve (+1) on 2020-08-03

Diff: 300 lines (+205/-17)

8 files modified

.coveragerc (+2/-0)
.gitignore (+2/-0)
hooks/hooks.py (+59/-13)
requirements.txt (+0/-0)
tests/unit/requirements.txt (+7/-0)
tests/unit/test_charm.py (+97/-0)
tests/unit/utils.py (+34/-0)
tox.ini (+4/-4)

api

Superseded for merging into ubuntu-mirror-charm:master

Ubuntu Mirror Charm Maintainers: Pending requested 2020-07-31

Diff: 182 lines (+86/-17)

7 files modified

.gitignore (+2/-0)
hooks/hooks.py (+50/-13)
hooks/utils.py (+11/-0)
requirements.txt (+0/-0)
tests/unit/requirements.txt (+6/-0)
tests/unit/test_charm.py (+13/-0)
tox.ini (+4/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

262d992... by Paul Collins on 2020-08-03

delete pointless CallableDict methods

Since we're subclassing dict and __call__ already uses
__getitem__, we wrote a bunch of extra code for no reason.

99cbd87... by Paul Collins on 2020-08-03

test configure_triggers

572e6ba... by Paul Collins on 2020-08-03

add tests for make_triggers and merge_shared_key_triggers

1c2896b... by Paul Collins on 2020-07-31

add test case for extract_ssh_public_key

7dff8e8... by Paul Collins on 2020-07-31

merge triggers where key is the same

eda2d44... by Paul Collins on 2020-07-31

ignore compiled Python

781c520... by Paul Collins on 2020-08-02

stop using python-apt

Replaced with charmhelpers.fetch.get_upstream_version.

This simplifies creating a unit-testing environment, since the version
of apt on PyPi seems to be very old.

9e0ddc5... by Paul Collins on 2020-07-30

refactor, eliminating globals

Reviewed-on: https://code.launchpad.net/~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/388436
Reviewed-by: Haw Loeung <email address hidden>

f1079ac... by Paul Collins on 2020-07-30

refactor, eliminating globals

cc09bd3... by Paul Collins on 2020-07-30

add lint and unittest, fix lint errors

Reviewed-on: https://code.launchpad.net/~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/388433
Reviewed-by: Haw Loeung <email address hidden>