~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm:remove-recursive-chown

Branch merges

Propose for merging

Merged into ubuntu-mirror-charm:master at revision e1693e24f472d137f3df5eeef453530476bb0f80

Haw Loeung: Approve (+1) on 2020-09-18

Canonical IS Reviewers: Pending requested 2020-09-18

Diff: 20 lines (+0/-2)

1 file modified

hooks/hooks.py (+0/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

c9d0b92... by Paul Collins on 2020-09-18

do not recursively chown /srv/ftp.root

There seems to be no reason to do this. The charm already creates the
root of the mirror path with the correct ownership, and the sync scripts
run as that user. chownr does not even change the ownership of the path
from which it begins its recursive chown!

4cb13e3... by Barry Price on 2020-09-18

Use nofail for all new bind mount entries

Suggested upgrade path here from the previous revno is, to avoid duplicated fstab entries:

1. Manually replace "defaults,bind" in /etc/fstab with "defaults,bind,nofail" on each unit
2. Upgrade-charm to a version with this update

Reviewed-on: https://code.launchpad.net/~barryprice/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/390792
Reviewed-by: Paul Collins <email address hidden>

3ee1f30... by Paul Collins on 2020-09-17

stop creating extra symlinks in mirror directories

Reviewed-on: https://code.launchpad.net/~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/390874
Reviewed-by: Haw Loeung <email address hidden>

0053527... by Paul Collins on 2020-09-17

stop creating extra symlinks in mirror directories

Due to a bug in charm-helpers (LP:1895914) when the charm tries to ensure
an existing www symlink exists, it ends up following www and creating an
additional bogus symlink in the mirror directory.

eda7335... by Barry Price on 2020-09-16

Use nofail for all new bind mount entries

4959511... by Paul Collins on 2020-09-16

now that rsync is managed via socket activation, there can be 0 processes

Reviewed-on: https://code.launchpad.net/~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/390780
Reviewed-by: Haw Loeung <email address hidden>

153bec4... by Paul Collins on 2020-09-16

now that rsync is managed via socket activation, there can be 0 processes

70d7abc... by Barry Price on 2020-09-15

Handle LP:1891566 by bind-mounting any paths outside /srv/ftp.root back into it, so that our chrooted vsftp can serve all the same files as apache2/rsync.

Reviewed-on: https://code.launchpad.net/~barryprice/ubuntu-mirror-charm/+git/ubuntu-mirror-charm/+merge/390394
Reviewed-by: Paul Collins <email address hidden>
Reviewed-by: Haw Loeung <email address hidden>

54910da... by Barry Price on 2020-09-10

Use freezegun for tests instead of passing datetime suffices around

d95c85e... by Barry Price on 2020-09-10

Clean up remove_bind_mount() logic