Merge lp:~pjdc/charms/trusty/rabbitmq-server/avoid-unresolvable-nodename-next-rebase into lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next

[Paul Collins]

In one of the Openstack clouds I work with, reverse DNS lookup of a unit's private IP yields a result of the form os-A-B-C-D.instance.openstack.internal. The rabbitmq-server charm snips off the first component and assumes, without checking, that this is a usable nodename. For a number of reasons, that is not the case in this deployment. This MP adds an assertion to check that the result of the reverse lookup resolves in the forward direction. If this fails, we fall back in the same manner as when no PTR record is present, which allows rabbitmq-server to deploy successfully in the cloud I am using.

[Resubmit with r106: "get_local_nodename: spell get_host_ip(nodename) correctly"]

[Resubmit to get the amulet test re-run; the previous failure looks transient.]

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #7920 rabbitmq-server-next for pjdc mp267733
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7920/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #7338 rabbitmq-server-next for pjdc mp267733
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7338/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #5761 rabbitmq-server-next for pjdc mp267733
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5761/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #7921 rabbitmq-server-next for pjdc mp267739
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7921/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #7339 rabbitmq-server-next for pjdc mp267739
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7339/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #5762 rabbitmq-server-next for pjdc mp267739
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12059688/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5762/

[Tom Haddon (mthaddon)]

This looks like a transient test failure but I can't be sure. Can someone confirm?

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #8246 rabbitmq-server-next for pjdc mp268283
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/8246/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #7645 rabbitmq-server-next for pjdc mp268283
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7645/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #5845 rabbitmq-server-next for pjdc mp268283
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12115685/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5845/

[Ryan Beisner (1chb1n)]

FYI - The existing amulet tests are known problematic, and are undergoing a rewrite at this time. I have a merge proposal work-in-progress to land fixed tests, hopefully soon.

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #7820 rabbitmq-server-next for pjdc mp268283
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/7820/

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #8426 rabbitmq-server-next for pjdc mp268283
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/8426/

[uosci-testing-bot (uosci-testing-bot)]

charm_amulet_test #5933 rabbitmq-server-next for pjdc mp268283
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
Timeout occurred, printing juju status...environment: osci-sv05
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12138264/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5933/

[Billy Olsen (billy-olsen)]

Thanks for the submission Paul! However, I think this branch is superceded by (now merged) branch https://code.launchpad.net/~niedbalski/charms/trusty/rabbitmq-server/fix-lp-1489053/+merge/269261.

Can you try with the /next branch and see if it is working for you?

review: Needs Information

[Paul Collins (pjdc)]

I was just about to, but now I see that it and a subsequent merge were reverted in r109.

Unmerged revisions

106. By Paul Collins on 2015-08-12

get_local_nodename: spell get_host_ip(nodename) correctly

105. By Paul Collins on 2015-08-12

get_local_nodename: ensure the resulting nodename itself resolves

=== modified file 'hooks/rabbitmq_server_relations.py'
--- hooks/rabbitmq_server_relations.py	2015-07-16 20:41:49 +0000
+++ hooks/rabbitmq_server_relations.py	2015-08-18 02:37:07 +0000
@@ -112,6 +112,9 @@
     log('getting local nodename for ip address: %s' % ip_addr, level=INFO)
     try:
         nodename = get_hostname(ip_addr, fqdn=False)
+        # Ensure that the resulting nodename resolves;
+        # if we can't resolve it, neither can rabbitmq.
+        get_host_ip(nodename)
     except:
         log('Cannot resolve hostname for %s using DNS servers' % ip_addr,
             level='WARNING')