Merge ~pjdc/charm-nrpe/+git/nrpe-charm:no-more-read-only into ~nrpe-charmers/charm-nrpe:master

Proposed by Paul Collins
Status: Merged
Merged at revision: 5614cde4a26b8200e34ad9ac14d1df15dfb333c0
Proposed branch: ~pjdc/charm-nrpe/+git/nrpe-charm:no-more-read-only
Merge into: ~nrpe-charmers/charm-nrpe:master
Diff against target: 27 lines (+3/-2)
2 files modified
hooks/nrpe_utils.py (+1/-1)
hooks/services.py (+2/-1)
Reviewer Review Type Date Requested Status
Paul Gear (community) Approve
Review via email: mp+324980@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Paul Gear (paulgear) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/hooks/nrpe_utils.py b/hooks/nrpe_utils.py
2index cddbfdb..89f8092 100644
3--- a/hooks/nrpe_utils.py
4+++ b/hooks/nrpe_utils.py
5@@ -50,7 +50,7 @@ def install_charm_files(service_name):
6 '/var/lib/nagios/export/']
7 for nag_dir in nag_dirs:
8 if not os.path.exists(nag_dir):
9- host.mkdir(nag_dir)
10+ host.mkdir(nag_dir, perms=0o755)
11 charm_file_dir = os.path.join(hookenv.charm_dir(), 'files')
12 charm_plugin_dir = os.path.join(charm_file_dir, 'plugins')
13 pkg_plugin_dir = '/usr/lib/nagios/plugins/'
14diff --git a/hooks/services.py b/hooks/services.py
15index 1c7da4b..9034981 100644
16--- a/hooks/services.py
17+++ b/hooks/services.py
18@@ -54,7 +54,8 @@ def manage():
19 helpers.render_template(
20 source='export_host.cfg.tmpl',
21 target='/var/lib/nagios/export/'
22- 'host__{}.cfg'.format(nag_hostname)
23+ 'host__{}.cfg'.format(nag_hostname),
24+ perms=0o644,
25 ),
26 ],
27 'start': [nrpe_utils.restart_rsync],

Subscribers

People subscribed via source and target branches