Merge ~pjdc/charm-k8s-mattermost/+git/image-build:install-patched-webapp into ~mattermost-charmers/charm-k8s-mattermost/+git/mattermost-k8s-image-builder:master

Proposed by Paul Collins
Status: Merged
Approved by: Tom Haddon
Approved revision: c6ddc6850b739e571fbe2c68b6c8844a5b71813d
Merged at revision: b992e0d37b9186943ff43797995f384bb8f47adc
Proposed branch: ~pjdc/charm-k8s-mattermost/+git/image-build:install-patched-webapp
Merge into: ~mattermost-charmers/charm-k8s-mattermost/+git/mattermost-k8s-image-builder:master
Diff against target: 41 lines (+11/-3)
1 file modified
Dockerfile (+11/-3)
Reviewer Review Type Date Requested Status
Benjamin Allot Approve
Canonical IS Reviewers Pending
Review via email: mp+386055@code.launchpad.net

Commit message

Install patched webapp with Canonical themes

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Unable to determine commit message from repository - please click "Set commit message" and enter the commit message manually.

Revision history for this message
Benjamin Allot (ballot) wrote :

LGTM with an inline comment

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has no commit message, setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change has no commit message, setting status to needs review.

Revision history for this message
Tom Haddon (mthaddon) wrote :

This is fine for now, but would like to chat on Monday/Tuesday (depending on which timezone you're in) about whether it's possible to build the patching of the web app into the docker build, otherwise we're going to need to manually build a patched version of the webapp every time a new one is released, which is going to make the upgrade process painful.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision b992e0d37b9186943ff43797995f384bb8f47adc

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 8529727..53f1d91 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,6 +1,6 @@
6 FROM ubuntu:focal
7
8-ENV MM_VERSION=5.22.1
9+ENV MM_VERSION=5.23.1
10
11 # Build argument to set Mattermost edition
12 ARG edition=enterprise
13@@ -10,9 +10,11 @@ ARG MM_BINARY=
14
15 RUN apt-get -qy update && \
16 apt-get -qy dist-upgrade && \
17- apt-get -qy install curl
18+ apt-get -qy install curl && \
19+ rm -f /var/lib/apt/lists/*_*
20
21 RUN mkdir -p /mattermost/data /mattermost/plugins /mattermost/client/plugins && \
22+ set -o pipefail && \
23 if [ ! -z "$MM_BINARY" ] ; then \
24 curl $MM_BINARY | tar -xvz ; \
25 elif [ "$edition" = "team" ] ; then \
26@@ -23,9 +25,15 @@ RUN mkdir -p /mattermost/data /mattermost/plugins /mattermost/client/plugins &&
27 addgroup --gid ${PGID} mattermost && \
28 adduser --no-create-home --disabled-password --gecos "" --uid ${PUID} --gid ${PGID} --home /mattermost mattermost
29
30+RUN rm -rf /mattermost/client && \
31+ set -o pipefail && \
32+ curl http://archive.admin.canonical.com/other/mattermost-webapp/${MM_VERSION}-canonical/mattermost-webapp.tar.gz | tar -C /mattermost -xvz
33+
34 RUN tar -C /mattermost/plugins -xvzf /mattermost/prepackaged_plugins/mattermost-plugin-autolink-v1.1.2-linux-amd64.tar.gz
35
36-RUN cd /mattermost/plugins && curl -L https://github.com/moussetc/mattermost-plugin-giphy/releases/download/v1.2.1/com.github.moussetc.mattermost.plugin.giphy-1.2.1.tar.gz | tar -xvz
37+RUN cd /mattermost/plugins && \
38+ set -o pipefail && \
39+ curl -L https://github.com/moussetc/mattermost-plugin-giphy/releases/download/v1.2.1/com.github.moussetc.mattermost.plugin.giphy-1.2.1.tar.gz | tar -xvz
40
41 HEALTHCHECK CMD curl --fail http://localhost:8065 || exit 1
42

Subscribers

People subscribed via source and target branches