Merge ~pjdc/charm-k8s-mattermost/+git/charm-k8s-mattermost:s3-wip into charm-k8s-mattermost:master

[Paul Collins]

Unmerged commits

d8c8a99... by Paul Collins on 2020-05-28

unit tests - XXX WIP DO NOT MERGE

9ea0964... by Paul Collins on 2020-05-28

add settings for S3 support

diff --git a/.gitignore b/.gitignore
index b25c15b..a41d835 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,4 @@
 *~
+.tox
+.coverage
+__pycache__
diff --git a/Makefile b/Makefile
new file mode 100644
index 0000000..4f10863
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,14 @@
+lint:
+	@echo "Running flake8"
+	@tox -e lint
+
+unittest:
+	@tox -e unit
+
+test: lint unittest
+
+clean:
+	@echo "Cleaning files"
+	@git clean -fXd
+
+.PHONY: lint test unittest clean
diff --git a/requirements.txt b/requirements.txt
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/requirements.txt
diff --git a/tests/unit/requirements.txt b/tests/unit/requirements.txt
new file mode 100644
index 0000000..65431fc
--- /dev/null
+++ b/tests/unit/requirements.txt
@@ -0,0 +1,4 @@
+mock
+pytest
+pytest-cov
+pyyaml
diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py
new file mode 100644
index 0000000..aab2a31
--- /dev/null
+++ b/tests/unit/test_charm.py
@@ -0,0 +1,47 @@
+#!/usr/bin/env python3
+
+import copy
+import unittest
+import sys
+
+sys.path.append('lib')  # noqa: E402
+sys.path.append('src')  # noqa: E402
+
+from charm import MattermostK8sCharm
+from ops import testing
+
+CONFIG_NO_S3_SETTINGS_S3_ENABLED = {
+    's3_enabled': True,
+    's3_endpoint': 's3.amazonaws.com',
+    's3_bucket': '',
+    's3_region': '',
+    's3_access_key_id': '',
+    's3_secret_access_key': '',
+}
+
+CONFIG_NO_S3_SETTINGS_S3_DISABLED_NO_DEFAULTS = {
+    's3_enabled': False,
+}
+
+
+class TestMattermostK8sCharm(unittest.TestCase):
+
+    def setUp(self):
+        self.harness = testing.Harness(
+            MattermostK8sCharm,
+            meta='''
+            name: mattermost
+            ''',
+        )
+
+        self.harness.begin()
+
+    def test_missing_charm_settings_no_s3_settings_s3_enabled(self):
+        self.harness.charm.model.config = copy.deepcopy(CONFIG_NO_S3_SETTINGS_S3_ENABLED)
+        expected = sorted(['s3_bucket', 's3_region', 's3_access_key_id', 's3_secret_access_key'])
+        self.assertEqual(sorted(self.harness.charm._missing_charm_settings()), expected)
+
+    def test_missing_charm_settings_no_s3_settings_s3_disabled_no_defaults(self):
+        self.harness.charm.model.config = copy.deepcopy(CONFIG_NO_S3_SETTINGS_S3_DISABLED_NO_DEFAULTS)
+        expected = []
+        self.assertEqual(sorted(self.harness.charm._missing_charm_settings()), expected)
diff --git a/tox.ini b/tox.ini
new file mode 100644
index 0000000..117984d
--- /dev/null
+++ b/tox.ini
@@ -0,0 +1,46 @@
+[tox]
+skipsdist=True
+envlist = unit, functional
+skip_missing_interpreters = True
+
+[testenv]
+basepython = python3
+setenv =
+  PYTHONPATH = .
+
+[testenv:unit]
+commands =
+    pytest --ignore mod --ignore {toxinidir}/tests/functional \
+      {posargs:-v  --cov=src --cov-report=term-missing --cov-branch}
+deps = -r{toxinidir}/tests/unit/requirements.txt
+       -r{toxinidir}/requirements.txt
+setenv =
+  PYTHONPATH={toxinidir}/lib
+  TZ=UTC
+
+[testenv:functional]
+passenv =
+  HOME
+  JUJU_REPOSITORY
+  PATH
+commands =
+	pytest -v --ignore mod --ignore {toxinidir}/tests/unit {posargs}
+deps = -r{toxinidir}/tests/functional/requirements.txt
+       -r{toxinidir}/requirements.txt
+
+[testenv:black]
+commands = black --skip-string-normalization --line-length=120 src/ tests/
+deps = black
+
+[testenv:lint]
+commands = flake8 src/ tests/
+deps =
+    flake8 == 3.7.9  # to match focal
+
+[flake8]
+exclude =
+    .git,
+    __pycache__,
+    .tox,
+max-line-length = 120
+max-complexity = 10