Merge lp:~pitti/unity8/notify-api-fix into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Michał Sawicz on 2015-01-07 |
| Approved revision: | 1524 |
| Merged at revision: | 1529 |
| Proposed branch: | lp:~pitti/unity8/notify-api-fix |
| Merge into: | lp:unity8 |
| Diff against target: |
10 lines (+0/-1) 1 file modified
tests/autopilot/unity8/shell/emulators/create_interactive_notification.py (+0/-1) |
| To merge this branch: | bzr merge lp:~pitti/unity8/notify-api-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michał Sawicz | 2015-01-06 | Approve on 2015-01-07 | |
| PS Jenkins bot | continuous-integration | Approve on 2015-01-06 | |
| Mirco Müller | 2015-01-07 | Pending | |
|
Review via email:
|
|||
Commit Message
tests: Fix Notify.
Description of the Change
Fix libnotify add_action invocation for bug 1223401. Please see the commit log
for details.
| Martin Pitt (pitti) wrote : | # |
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1524
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Martin Pitt (pitti) wrote : | # |
The notification tests like
13:45:46.652 INFO testresult:44 - OK: unity8.
ran ok.
| Michał Sawicz (saviq) wrote : | # |
W dniu 06.01.2015 o 15:43, Martin Pitt pisze:
> The notification tests like
>
> 13:45:46.652 INFO testresult:44 - OK: unity8.
>
> ran ok.
Yeah, sorry about that, need to investigate the flakiness.
Have triggered a re-run in the mean time.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1524
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Clarification for specifying "None, None": With the patched Ubuntu API, the second "None" will just be ignored (that's the free_func argument) and the callback will get one user_data argument, exactly what it expects:
def action_
But with the upstream API, action_callback will get a second data argument with the second None, due to how pygobject handles a list of user_data arguments.
With just specifying "None", action_callback will get a single data (None) in both cases. See the bug trail for even more details and python single-liners to illustrate this.