Merge lp:~pitti/unity/gdk-api into lp:unity

[Martin Pitt]

Disable fatal deprecation warnings to build with zesty's GTK 3.22 without breaking backportability.

Disable fatal deprecation warnings

Gtk 3.22 deprecated GdkScreen in favor of GdkMonitor. This is quite
intrusive to port and would prevent being able to build unity on Ubuntu
16.04 or 16.10. (This would involve porting 50 places in the code).

Using deprecated symbols is not an error, so disable build failures due to
them.

[Martin Pitt (pitti)]

See https://launchpadlibrarian.net/290975162/buildlog_ubuntu-zesty-amd64.unity_7.5.0+17.04.20161026-0ubuntu1_BUILDING.txt.gz for FTBFS

[Marco Trevisan (Treviño) (3v1n0)]

I agree we can make these warnings not to be fatal anymore.

Thanks

review: Approve

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2016-09-01 11:22:22 +0000
+++ CMakeLists.txt	2016-10-26 21:38:41 +0000
@@ -209,7 +209,7 @@
     SET (BOOT_LOGGER_FLAG "-DENABLE_LOGGER")
 endif (BOOT_LOGGER)
 
-SET (MAINTAINER_CXXFLAGS "-Werror -Wall -Wcast-align -Wempty-body -Wformat-security -Winit-self -Warray-bounds")
+SET (MAINTAINER_CXXFLAGS "-Werror -Wall -Wcast-align -Wempty-body -Wformat-security -Winit-self -Warray-bounds -Wno-error=deprecated-declarations")
 
 option (DISABLE_ERROR_ON_LOCAL_TYPEDEFS_WARNINGS "Disable errors when local typedefs are unused" ON)
 if (DISABLE_ERROR_ON_LOCAL_TYPEDEFS_WARNINGS)

=== modified file 'services/CMakeLists.txt'
--- services/CMakeLists.txt	2016-08-31 15:57:01 +0000
+++ services/CMakeLists.txt	2016-10-26 21:38:41 +0000
@@ -35,7 +35,7 @@
 set(CFLAGS
     ${SERVICE_DEPS_CFLAGS}
     ${SERVICE_DEPS_CFLAGS_OTHER}
-    "-Werror -Wall"
+    "-Werror -Wall -Wno-error=deprecated-declarations"
     )
 
 string (REPLACE ";" " " CFLAGS "${CFLAGS}")