Merge lp:~pitti/unity-2d/fix-gsettings-migration into lp:unity-2d

Proposed by Martin Pitt
Status: Merged
Approved by: Gerry Boland
Approved revision: 867
Merged at revision: 872
Proposed branch: lp:~pitti/unity-2d/fix-gsettings-migration
Merge into: lp:unity-2d
Diff against target: 49 lines (+14/-3)
4 files modified
data/unity-2d.convert (+0/-1)
debian/changelog (+12/-0)
debian/control (+1/-1)
debian/source/format (+1/-1)
To merge this branch: bzr merge lp:~pitti/unity-2d/fix-gsettings-migration
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Review via email: mp+89882@code.launchpad.net

Description of the change

r802 removed the "use-struts" gsettings option, but forgot to remove it from
the gconf migration schema as well. This causes gsettings-data-convert to
crash, causing the whole configuration migration to fail.

Please apply quickly. Thanks!

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

As discussed with Didier, I'm uploading this now as it's a major regression since December. If you merge this, don't worry about preserving the changelog, that's not important.

Thanks!

866. By Martin Pitt

debian/source/format: Move back to 1.0, as we have inline code changes
with the full code being branched from trunk. Current dpkg makes it
impossible to build a source package with 3.0 now.

867. By Martin Pitt

releasing version 5.2.0-0ubuntu2

Revision history for this message
Martin Pitt (pitti) wrote :

Note, I also had to change the source package format from 3.0 (quilt) to 1.0, otherwise precise's dpkg fails to build a source package (and the --commit option doesn't seem to work).

Revision history for this message
Gerry Boland (gerboland) wrote :

Ok, I was confused by the change of source package format, but a quick chat with didrocks has sorted that out for me.
Thank you for the fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/unity-2d.convert'
2--- data/unity-2d.convert 2011-08-02 10:15:06 +0000
3+++ data/unity-2d.convert 2012-01-24 13:20:31 +0000
4@@ -1,5 +1,4 @@
5 [com.canonical.Unity2d.Launcher]
6 super-key-enable = /desktop/unity-2d/launcher/super_key_enable
7 hide-mode = /desktop/unity-2d/launcher/hide_mode
8-use-strut = /desktop/unity-2d/launcher/use_strut
9
10
11=== modified file 'debian/changelog'
12--- debian/changelog 2012-01-13 08:13:09 +0000
13+++ debian/changelog 2012-01-24 13:20:31 +0000
14@@ -1,3 +1,15 @@
15+unity-2d (5.2.0-0ubuntu2) precise; urgency=low
16+
17+ * debian/control: Fix Vcs-Bzr: to point to precise/trunk branch.
18+ * data/unity-2d.convert: Drop invalid "use-strut". This gsettings key does
19+ not exist and causes gsettings-data-convert to crash, making the whole
20+ settings migration fail. This cleans up after r804. (LP: #920894)
21+ * debian/source/format: Move back to 1.0, as we have inline code changes
22+ with the full code being branched from trunk. Current dpkg makes it
23+ impossible to build a source package with 3.0 now.
24+
25+ -- Martin Pitt <martin.pitt@ubuntu.com> Tue, 24 Jan 2012 14:11:16 +0100
26+
27 unity-2d (5.2.0-0ubuntu1) precise; urgency=low
28
29 [ Didier Roche ]
30
31=== modified file 'debian/control'
32--- debian/control 2012-01-12 17:21:09 +0000
33+++ debian/control 2012-01-24 13:20:31 +0000
34@@ -26,7 +26,7 @@
35 libnux-2.0-dev (>= 2.0),
36 libxi-dev,
37 Standards-Version: 3.9.2
38-Vcs-Bzr: http://bazaar.launchpad.net/~unity-2d-team/unity-2d/oneiric
39+Vcs-Bzr: https://code.launchpad.net/~unity-2d-team/unity-2d/trunk
40
41 Package: unity-2d
42 Architecture: all
43
44=== modified file 'debian/source/format'
45--- debian/source/format 2011-01-15 02:08:47 +0000
46+++ debian/source/format 2012-01-24 13:20:31 +0000
47@@ -1,1 +1,1 @@
48-3.0 (quilt)
49+1.0

Subscribers

People subscribed via source and target branches