Merge lp:~pitti/ubiquity/indicator-soname into lp:ubiquity

Proposed by Martin Pitt
Status: Merged
Merged at revision: 5271
Proposed branch: lp:~pitti/ubiquity/indicator-soname
Merge into: lp:ubiquity
Diff against target: 31 lines (+8/-2) (has conflicts)
2 files modified
debian/changelog (+7/-0)
tests/test_migrationassistant.py (+1/-2)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~pitti/ubiquity/indicator-soname
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+98230@code.launchpad.net

Description of the change

Fix the tests to work with pygobject 3.1.92, which fixed the return API of get_visible_range().

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Sorry for the bad branch name, I accidentally re-used an older one.

Revision history for this message
Colin Watson (cjwatson) wrote :

Needs to tolerate both old and new pygobject, at least for now; I'll fix that up locally as discussed on IRC.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-19 16:37:36 +0000
3+++ debian/changelog 2012-03-19 16:38:27 +0000
4@@ -13,7 +13,14 @@
5 * Merge and update Alessio Treglia's branch to make the slideshow
6 optional depending on (ubiquity/hide_slideshow) (LP: #690912)
7
8+<<<<<<< TREE
9 -- Stéphane Graber <stgraber@ubuntu.com> Mon, 19 Mar 2012 12:22:59 -0400
10+=======
11+ [ Martin Pitt ]
12+ * tests/test_migrationassistant.py: Fix to work with pygobject 3.1.92.
13+
14+ -- Stéphane Graber <stgraber@ubuntu.com> Mon, 19 Mar 2012 11:48:43 -0400
15+>>>>>>> MERGE-SOURCE
16
17 ubiquity (2.9.29) precise; urgency=low
18
19
20=== modified file 'tests/test_migrationassistant.py'
21--- tests/test_migrationassistant.py 2012-03-06 00:28:03 +0000
22+++ tests/test_migrationassistant.py 2012-03-19 16:38:27 +0000
23@@ -37,7 +37,6 @@
24 })
25 ma_page.ui.ma_set_choices(tree)
26 ui.refresh()
27- valid, start_path, end_path = ui.matreeview.get_visible_range()
28- self.assertTrue(valid)
29+ start_path, end_path = ui.matreeview.get_visible_range()
30 self.assertEqual('0', start_path.to_string())
31 self.assertEqual('3', end_path.to_string())

Subscribers

People subscribed via source and target branches

to status/vote changes: