Merge lp:~pitti/notify-osd/fix-autopkgtest into lp:notify-osd

Proposed by Martin Pitt
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 486
Merged at revision: 484
Proposed branch: lp:~pitti/notify-osd/fix-autopkgtest
Merge into: lp:notify-osd
Diff against target: 19 lines (+5/-2)
2 files modified
debian/tests/control (+1/-1)
debian/tests/upstream (+4/-1)
To merge this branch: bzr merge lp:~pitti/notify-osd/fix-autopkgtest
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+219293@code.launchpad.net

Commit message

Add missing "make" and "libnotify-bin" autopkgtest dependencies, and show test log on failure.

Description of the change

The autopkgtest currently fails [1] because the test runs "make", but doesn't
depend on it. Trivial and tested fix.

[1] https://jenkins.qa.ubuntu.com/job/utopic-adt-notify-osd/10/ARCH=i386,label=adt/console

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

Locally tested again with both the failing case (for seeing the failed log) and succeeding case. (adt-run -B .// --- qemu adt-utopic-amd64-cloud.img)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/tests/control'
2--- debian/tests/control 2013-07-25 13:47:37 +0000
3+++ debian/tests/control 2014-08-19 13:34:01 +0000
4@@ -1,3 +1,3 @@
5 Tests: upstream
6-Depends: @, dbus-x11, gnome-screensaver, hicolor-icon-theme, xvfb, at-spi2-core
7+Depends: @, make, dbus-x11, gnome-screensaver, hicolor-icon-theme, xvfb, at-spi2-core, libnotify-bin
8 Restrictions: build-needed
9
10=== modified file 'debian/tests/upstream'
11--- debian/tests/upstream 2012-11-26 20:17:09 +0000
12+++ debian/tests/upstream 2014-08-19 13:34:01 +0000
13@@ -1,2 +1,5 @@
14 #!/bin/sh
15-xvfb-run --server-args="-screen 0 800x600x8" make check
16+if ! xvfb-run --server-args="-screen 0 800x600x8" make check; then
17+ cat tests/test-suite.log >&2
18+ exit 1
19+fi

Subscribers

People subscribed via source and target branches