Merge lp:~pitti/indicator-session/upower into lp:indicator-session/0.1

Proposed by Martin Pitt
Status: Merged
Merged at revision: not available
Proposed branch: lp:~pitti/indicator-session/upower
Merge into: lp:indicator-session/0.1
Diff against target: 147 lines (+30/-30)
1 file modified
src/session-service.c (+30/-30)
To merge this branch: bzr merge lp:~pitti/indicator-session/upower
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+19472@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

This is a straightforward port from DeviceKit-Power to upower D-Bus API. It does not solve the problem of checking whether the user is allowed to suspend/hibernate yet, but it already helps us to stop triggering devicekit-power in addition to upower.

Revision history for this message
Martin Pitt (pitti) wrote :

NB that _either_ this branch _or_ https://code.launchpad.net/~pitti/indicator-session/libupower-glib/+merge/19392 should be merged, not both.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/session-service.c'
2--- src/session-service.c 2010-02-08 22:46:35 +0000
3+++ src/session-service.c 2010-02-17 10:08:16 +0000
4@@ -44,9 +44,9 @@
5 #include "users-service-dbus.h"
6 #include "lock-helper.h"
7
8-#define DKP_ADDRESS "org.freedesktop.DeviceKit.Power"
9-#define DKP_OBJECT "/org/freedesktop/DeviceKit/Power"
10-#define DKP_INTERFACE "org.freedesktop.DeviceKit.Power"
11+#define UP_ADDRESS "org.freedesktop.UPower"
12+#define UP_OBJECT "/org/freedesktop/UPower"
13+#define UP_INTERFACE "org.freedesktop.UPower"
14
15 #define GUEST_SESSION_LAUNCHER "/usr/share/gdm/guest-session/guest-session-launch"
16
17@@ -72,8 +72,8 @@
18
19 static DbusmenuMenuitem * root_menuitem = NULL;
20 static GMainLoop * mainloop = NULL;
21-static DBusGProxy * dkp_main_proxy = NULL;
22-static DBusGProxy * dkp_prop_proxy = NULL;
23+static DBusGProxy * up_main_proxy = NULL;
24+static DBusGProxy * up_prop_proxy = NULL;
25
26 static DBusGProxyCall * suspend_call = NULL;
27 static DBusGProxyCall * hibernate_call = NULL;
28@@ -147,14 +147,14 @@
29 {
30 gchar * type = (gchar *)userdata;
31
32- if (dkp_main_proxy == NULL) {
33- g_warning("Can not %s as no DeviceKit Power Proxy", type);
34+ if (up_main_proxy == NULL) {
35+ g_warning("Can not %s as no upower proxy", type);
36 }
37
38 screensaver_throttle(type);
39 lock_screen(NULL, 0, NULL);
40
41- dbus_g_proxy_begin_call(dkp_main_proxy,
42+ dbus_g_proxy_begin_call(up_main_proxy,
43 type,
44 sleep_response,
45 NULL,
46@@ -213,17 +213,17 @@
47 /* A signal that we need to recheck to ensure we can still
48 hibernate and/or suspend */
49 static void
50-dpk_changed_cb (DBusGProxy * proxy, gpointer user_data)
51+up_changed_cb (DBusGProxy * proxy, gpointer user_data)
52 {
53 /* Start Async call to see if we can hibernate */
54 if (suspend_call == NULL) {
55- suspend_call = dbus_g_proxy_begin_call(dkp_prop_proxy,
56+ suspend_call = dbus_g_proxy_begin_call(up_prop_proxy,
57 "Get",
58 suspend_prop_cb,
59 NULL,
60 NULL,
61 G_TYPE_STRING,
62- DKP_INTERFACE,
63+ UP_INTERFACE,
64 G_TYPE_STRING,
65 "can-suspend",
66 G_TYPE_INVALID,
67@@ -233,13 +233,13 @@
68
69 /* Start Async call to see if we can suspend */
70 if (hibernate_call == NULL) {
71- hibernate_call = dbus_g_proxy_begin_call(dkp_prop_proxy,
72+ hibernate_call = dbus_g_proxy_begin_call(up_prop_proxy,
73 "Get",
74 hibernate_prop_cb,
75 NULL,
76 NULL,
77 G_TYPE_STRING,
78- DKP_INTERFACE,
79+ UP_INTERFACE,
80 G_TYPE_STRING,
81 "can-hibernate",
82 G_TYPE_INVALID,
83@@ -254,39 +254,39 @@
84 DKp checking. We're even setting up the calls for the props
85 we need */
86 static void
87-setup_dkp (void) {
88+setup_up (void) {
89 DBusGConnection * bus = dbus_g_bus_get(DBUS_BUS_SYSTEM, NULL);
90 g_return_if_fail(bus != NULL);
91
92- if (dkp_main_proxy == NULL) {
93- dkp_main_proxy = dbus_g_proxy_new_for_name(bus,
94- DKP_ADDRESS,
95- DKP_OBJECT,
96- DKP_INTERFACE);
97+ if (up_main_proxy == NULL) {
98+ up_main_proxy = dbus_g_proxy_new_for_name(bus,
99+ UP_ADDRESS,
100+ UP_OBJECT,
101+ UP_INTERFACE);
102 }
103- g_return_if_fail(dkp_main_proxy != NULL);
104+ g_return_if_fail(up_main_proxy != NULL);
105
106- if (dkp_prop_proxy == NULL) {
107- dkp_prop_proxy = dbus_g_proxy_new_for_name(bus,
108- DKP_ADDRESS,
109- DKP_OBJECT,
110+ if (up_prop_proxy == NULL) {
111+ up_prop_proxy = dbus_g_proxy_new_for_name(bus,
112+ UP_ADDRESS,
113+ UP_OBJECT,
114 DBUS_INTERFACE_PROPERTIES);
115 }
116- g_return_if_fail(dkp_prop_proxy != NULL);
117+ g_return_if_fail(up_prop_proxy != NULL);
118
119 /* Connect to changed signal */
120- dbus_g_proxy_add_signal(dkp_main_proxy,
121+ dbus_g_proxy_add_signal(up_main_proxy,
122 "Changed",
123 G_TYPE_INVALID);
124
125- dbus_g_proxy_connect_signal(dkp_main_proxy,
126+ dbus_g_proxy_connect_signal(up_main_proxy,
127 "Changed",
128- G_CALLBACK(dpk_changed_cb),
129+ G_CALLBACK(up_changed_cb),
130 NULL,
131 NULL);
132
133 /* Force an original "changed" event */
134- dpk_changed_cb(dkp_main_proxy, NULL);
135+ up_changed_cb(up_main_proxy, NULL);
136
137 return;
138 }
139@@ -639,7 +639,7 @@
140 G_CALLBACK (user_removed),
141 root_menuitem);
142
143- setup_dkp();
144+ setup_up();
145
146 DbusmenuServer * server = dbusmenu_server_new(INDICATOR_SESSION_DBUS_OBJECT);
147 dbusmenu_server_set_root(server, root_menuitem);

Subscribers

People subscribed via source and target branches