Merge lp:~pitti/indicator-network/systemd-unit into lp:indicator-network

Proposed by Martin Pitt
Status: Merged
Approved by: Martin Pitt
Approved revision: 615
Merged at revision: 637
Proposed branch: lp:~pitti/indicator-network/systemd-unit
Merge into: lp:indicator-network
Diff against target: 126 lines (+65/-1)
7 files modified
data/CMakeLists.txt (+41/-0)
data/indicator-network-secret-agent.override (+1/-0)
data/indicator-network-secret-agent.service.in (+7/-0)
data/indicator-network.override (+1/-0)
data/indicator-network.service.in (+9/-0)
debian/control (+4/-1)
debian/indicator-network.install (+2/-0)
To merge this branch: bzr merge lp:~pitti/indicator-network/systemd-unit
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+308790@code.launchpad.net

Commit message

Add systemd user unit

Description of the change

Add systemd unit. This replaces https://code.launchpad.net/~ted/indicator-network/systemd-unit/+merge/300443 as the latter got stale (needed trunk merge).

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/CMakeLists.txt'
2--- data/CMakeLists.txt 2015-11-20 13:14:50 +0000
3+++ data/CMakeLists.txt 2016-10-19 10:37:13 +0000
4@@ -55,6 +55,47 @@
5 )
6
7 ###########################
8+# Indicator-network systemd jobs
9+###########################
10+
11+# Uncomment when we drop Vivid
12+# pkg_get_variable(SYSTEMD_USER_DIR systemd systemduserunitdir)
13+set (SYSTEMD_USER_DIR "/usr/lib/systemd/user")
14+message (STATUS "${SYSTEMD_USER_DIR} is the systemd user unit file install dir")
15+
16+configure_file (
17+ indicator-network-secret-agent.service.in
18+ indicator-network-secret-agent.service
19+ @ONLY
20+)
21+
22+configure_file (
23+ indicator-network.service.in
24+ indicator-network.service
25+ @ONLY
26+)
27+
28+install (
29+ FILES "${CMAKE_CURRENT_BINARY_DIR}/indicator-network-secret-agent.service"
30+ DESTINATION ${SYSTEMD_USER_DIR}
31+)
32+
33+install (
34+ FILES "${CMAKE_CURRENT_BINARY_DIR}/indicator-network.service"
35+ DESTINATION ${SYSTEMD_USER_DIR}
36+)
37+
38+###########################
39+# Indicator-network systemd Upstart overrides
40+###########################
41+
42+set (SYSTEMD_UPSTART_DIR "${CMAKE_INSTALL_FULL_DATADIR}/upstart/systemd-session/upstart")
43+install (
44+ FILES indicator-network.override indicator-network-secret-agent.override
45+ DESTINATION ${SYSTEMD_UPSTART_DIR}
46+)
47+
48+###########################
49 # GSettings
50 ###########################
51
52
53=== added file 'data/indicator-network-secret-agent.override'
54--- data/indicator-network-secret-agent.override 1970-01-01 00:00:00 +0000
55+++ data/indicator-network-secret-agent.override 2016-10-19 10:37:13 +0000
56@@ -0,0 +1,1 @@
57+manual
58
59=== added file 'data/indicator-network-secret-agent.service.in'
60--- data/indicator-network-secret-agent.service.in 1970-01-01 00:00:00 +0000
61+++ data/indicator-network-secret-agent.service.in 2016-10-19 10:37:13 +0000
62@@ -0,0 +1,7 @@
63+[Unit]
64+Description=Indicator Network Secret Agent
65+PartOf=indicator-network.service
66+
67+[Service]
68+ExecStart=@AGENT_SERVICE@
69+Restart=on-failure
70
71=== added file 'data/indicator-network.override'
72--- data/indicator-network.override 1970-01-01 00:00:00 +0000
73+++ data/indicator-network.override 2016-10-19 10:37:13 +0000
74@@ -0,0 +1,1 @@
75+manual
76
77=== added file 'data/indicator-network.service.in'
78--- data/indicator-network.service.in 1970-01-01 00:00:00 +0000
79+++ data/indicator-network.service.in 2016-10-19 10:37:13 +0000
80@@ -0,0 +1,9 @@
81+[Unit]
82+Description=Indicator Network Backend
83+PartOf=graphical-session.target
84+After=indicators-pre.target
85+Wants=indicator-network-secret-agent.service
86+
87+[Service]
88+ExecStart=@NETWORK_SERVICE@
89+Restart=on-failure
90
91=== modified file 'debian/control'
92--- debian/control 2016-09-20 14:53:16 +0000
93+++ debian/control 2016-10-19 10:37:13 +0000
94@@ -30,7 +30,9 @@
95 qtbase5-dev-tools,
96 qtdeclarative5-dev,
97 qtdeclarative5-dev-tools,
98- qttools5-dev-tools
99+ qttools5-dev-tools,
100+ valgrind [amd64 armhf i386 powerpc],
101+ systemd,
102 Standards-Version: 3.9.5
103 # If you aren't a member of ~indicator-applet-developers but need to upload
104 # packaging changes, just go ahead. ~indicator-applet-developers will notice
105@@ -45,6 +47,7 @@
106 Multi-Arch: foreign
107 Depends: ${misc:Depends},
108 ${shlibs:Depends},
109+ indicator-common,
110 network-manager,
111 network-manager-openvpn,
112 network-manager-pptp,
113
114=== modified file 'debian/indicator-network.install'
115--- debian/indicator-network.install 2015-12-04 13:18:04 +0000
116+++ debian/indicator-network.install 2016-10-19 10:37:13 +0000
117@@ -1,7 +1,9 @@
118 usr/share/upstart/xdg/autostart/indicator-network.desktop
119 usr/share/upstart/sessions/*
120+usr/share/upstart/systemd-session
121 usr/share/glib-2.0/schemas/com.canonical.indicator.network.gschema.xml
122 usr/share/unity/indicators/com.canonical.indicator.network
123 usr/lib/*/indicator-network/*
124+usr/lib/systemd
125 etc/xdg/autostart/indicator-network.desktop
126 usr/share/locale

Subscribers

People subscribed via source and target branches