Merge lp:~pitti/gtimelog/pygi into lp:~gtimelog-dev/gtimelog/trunk
Proposed by
Martin Pitt
Status: | Merged |
---|---|
Approved by: | Barry Warsaw |
Approved revision: | 198 |
Merged at revision: | 196 |
Proposed branch: | lp:~pitti/gtimelog/pygi |
Merge into: | lp:~gtimelog-dev/gtimelog/trunk |
Diff against target: |
37 lines (+11/-1) 2 files modified
NEWS.txt (+5/-0) src/gtimelog/main.py (+6/-1) |
To merge this branch: | bzr merge lp:~pitti/gtimelog/pygi |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Barry Warsaw | Approve | ||
Review via email: mp+76169@code.launchpad.net |
Description of the change
Seems 0.6 accidentally dropped the required import of "gi" when using GI. Also, it seems my TabAlign.LEFT -> TabAlign.TAB_LEFT change was wrong, this is due to a broken .gir of Pango in the Ubuntu packages. With upstream Pango it really is TabAlign.LEFT, as it is supposed to be with GIR. However, I added a backwards compat quirk to work with either.
With this, gtimelog again works fine in jhbuild with current GTK3/Pango/etc.
To post a comment you must log in.
Thanks Martin, this looks great. I'll commit this to trunk, but I want to hold off on uploading it to Ubuntu until I can fix the quit-button issue (i.e. ctrl-Q works but the quit button only closes the window).