Code review comment for lp:~pitti/computer-janitor/pygi

Barry Warsaw (barry) wrote :

Thanks Martin, this looks really good. I'm going to go ahead and merge it, with a few minor changes (which I'll make after the merge):

* Bump version number to 2.1
* Update copyright years
* Tweak a few Python style things
* Use logging instead of stderr for the popup message

On the latter, what do you think about adding an Edit menu that has the following items:

Select all
Select all packages
Select all other
Unselect all
Unselect all packages
Unselect all other

That would at least provide the missing functionality elsewhere, and we could even keep that when using gtk3.

review: Approve

« Back to merge proposal