Code review comment for lp:~pitti/autopilot-gtk/testsuite

Revision history for this message
Francis Ginther (fginther) wrote :

> While developing some actual tests in lp:~pitti/autopilot-gtk/add-tests I
> noticed that running under xvfb-run takes very long, and also has some quirks
> (like, the "has_focus" property is false for a GtkEntry where it ought to be
> true). I think we should take the "make test"/"ctest" integration, but I'd
> appreciate an opinion whether you want the tests to run during package build
> (in debian/rules), or whether there is a more elegant way to let them run for
> merge proposals (i. e. CI testing) which runs them in an actual X session?

Running these tests under a real X environment is a next step. There is actually a blueprint item for this month to make this possible for lp:autopilot which can then be extended here. However, until that is ready, I'm ok with adding these tests and running them with xvfb in order to get some testing enabled. Eventually we'll need to split out the autopilot tests and create a separate set of unittests that will be run during package build (and not require X).

The only thing I would address in this MP is the test runner used. I believe we should be using autopilot, but I can't figure out how to make it work. I'm currently trying this:

add_test(autopilot-gtk-functional autopilot run -f xml -o test-autopilot-gtk-functional.xml -v tests)

but I don't have the source directory right and it can't find the tests.

review: Needs Fixing

« Back to merge proposal