Merge lp:~pitti/autopilot-gtk/gtkbuilder-names into lp:autopilot-gtk
Proposed by
Martin Pitt
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Martin Pitt | ||||
Approved revision: | 48 | ||||
Merged at revision: | 48 | ||||
Proposed branch: | lp:~pitti/autopilot-gtk/gtkbuilder-names | ||||
Merge into: | lp:autopilot-gtk | ||||
Diff against target: |
126 lines (+36/-27) 3 files modified
lib/GtkNode.cpp (+9/-0) tests/autopilot/tests/test_actions.py (+4/-18) tests/autopilot/tests/test_properties.py (+23/-9) |
||||
To merge this branch: | bzr merge lp:~pitti/autopilot-gtk/gtkbuilder-names | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Thomi Richards (community) | Approve | ||
Review via email: mp+171709@code.launchpad.net |
Commit message
Expose GtkBuilder widget identifiers as "BuilderName" property. (LP: #1082391)
Description of the change
The objects on the application widget tree should have proper identifiers that
are given to them in the GtkBuilder .ui files. These identifiers are the ones
that the actual program code uses to refer to them, so they are both stable,
and also the most appropriate means to identify a particular widget.
This branch exposes them as "BuilderName" property (capitalized to avoid
potential conflict with real GTK widget properties), and adds/updates the test
cases accordingly.
To post a comment you must log in.
PASSED: Continuous integration, rev:47 jenkins. qa.ubuntu. com/job/ autopilot- gtk-ci/ 56/ jenkins. qa.ubuntu. com/job/ autopilot- gtk-saucy- amd64-ci/ 18 jenkins. qa.ubuntu. com/job/ autopilot- gtk-saucy- armhf-ci/ 18
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ autopilot- gtk-ci/ 56/rebuild
http://