Code review comment for lp:~pitti/autopilot-gtk/add-tests

Francis Ginther (fginther) wrote :

So I had some trouble running the tests on raring outside of the package build (i.e. "cmake .; make; make test"). But it all ran fine under saucy. The failures are in:

tests.test_actions.ActionsTest.test_menu
 - The test attempts to open the menu where it would appear if it were embedded in the app window, but my menu is in the unity panel.

tests.test_gnome_system_log.GnomeAppTest.test_search
 - This test fails because it can't find the 'GdRevealer'. Possibly this doesn't exist in the saucy version of gnome-system-log?

Given that the failures are not seen on saucy (where development is targeted). I don't see a reason not to approve.

review: Approve

« Back to merge proposal