branches with status:
Name Status Last Modified Last Commit
lp:~piotr-sikora/libmemcached/fix-tests-on-openbsd (Has a merge proposal) 1 Development 2011-07-14 12:18:46 UTC
948. server_startup: whitelist ECONNREFUSE...

Author: Piotr Sikora
Revision Date: 2011-07-14 11:55:06 UTC

server_startup: whitelist ECONNREFUSED in fopen's errno switch.

It seems that because errno doesn't get cleared, the problematic switch
relies on errno value propagated not only from the failed fopen(), but
also from libmemcached_util_ping() call ~100 lines before.

Running tests on OpenBSD resulted in such error:

  Could not open pid file /tmp/memcached.pidXXXXXX -> fopen(Connection refused)

which obviously doesn't make any sense.

This change fixes that and allows tests to run.

lp:~piotr-sikora/libmemcached/connect-fix (Has a merge proposal) 1 Development 2011-07-14 11:32:25 UTC
948. network_connect: return MEMCACHED_SUC...

Author: Piotr Sikora
Revision Date: 2011-07-14 11:27:04 UTC

network_connect: return MEMCACHED_SUCCESS on successful connection.

Currently, we're breaking into "error handling code path" if the
non-blocking connect() succeeds immediately instead of returning
success.

12 of 2 results