Merge lp:~piiramar/dialer-app/dial-tones into lp:dialer-app

[Martti Piirainen]

Adding audible/haptic feedback while dialing (LP: #1228711).

Fixes bug 1228711. Needs https://code.launchpad.net/~piiramar/telephony-service/tone-generation/+merge/228983 .

[lp:~piiramar/dialer-app/dial-tones]

211. By Martti Piirainen on 2014-08-07

Adapt to changed DTMF function name

212. By Martti Piirainen on 2014-08-07

Merged from trunk

[Martti Piirainen (piiramar)]

Minor update to incorporate a changed API function name.

-- Checklist --
Are there any related MPs required for this MP to build/function as expected? Please list.
Yes, https://code.launchpad.net/~piiramar/telephony-service/tone-generation/+merge/228983

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/dialer-app) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
Yes, UX change approved in bug 1228711 on 2014-07-30.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

[Tiago Salem Herrmann (tiagosh)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
CI did not run at all. will test in the silo.

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve

=== modified file 'src/qml/DialerPage/DialerPage.qml'
--- src/qml/DialerPage/DialerPage.qml	2014-08-04 18:47:45 +0000
+++ src/qml/DialerPage/DialerPage.qml	2014-08-07 12:23:32 +0000
@@ -298,6 +298,7 @@
 
             onKeyPressed: {
                 input.insert(input.cursorPosition, label)
+                callManager.playTone(label);
             }
         }
     }