Merge ~pieq/plainbox-provider-resource:1649464-sorting-bus-hex-id into plainbox-provider-resource:master
Proposed by
Pierre Equoy
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | 81d448047cf1854f2169c1de9f0a09fade92ef4c |
Merged at revision: | 9e93ef16c36f89f6d6dc8d943d36c334bf880f50 |
Proposed branch: | ~pieq/plainbox-provider-resource:1649464-sorting-bus-hex-id |
Merge into: | plainbox-provider-resource:master |
Diff against target: |
11 lines (+1/-1) 1 file modified
bin/graphics_card_resource (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sylvain Pineau (community) | Approve | ||
Review via email: mp+315197@code.launchpad.net |
Description of the change
Fix graphics card bus ordering when bus ID contains hexadecimal values
The PCI bus ID that we use in the graphics card resource job in order to sort
the available graphics cards can contain hexadecimal values (e.g. 'b3') and not
only decimal values.
We now make sure these values are converted into decimal before comparing them.
To test it, you can launch (in a venv running checkbox):
./graphics_
This problem occurred on servers being tested with graphics cards, so it might be interesting to test it on similar devices. We had indeed never seen this issue before on desktops/laptops.
To post a comment you must log in.
Very pythonic, +1