Merge ~pieq/plainbox-provider-resource:fix-amdgpu-pro-check into plainbox-provider-resource:master

Proposed by Pierre Equoy
Status: Merged
Approved by: Sylvain Pineau
Approved revision: e39890cb78850d90668202b929b9326f4beba1ba
Merged at revision: e9310744df5e82a220f43fbc97424b808fdb28f3
Proposed branch: ~pieq/plainbox-provider-resource:fix-amdgpu-pro-check
Merge into: plainbox-provider-resource:master
Diff against target: 13 lines (+1/-1)
1 file modified
bin/graphics_card_resource (+1/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+310402@code.launchpad.net

Description of the change

Change method to check presence of amdgpu-pro stack

The Vulkan drivers are only included in amdgpu-pro stacks.
We check if the related package is installed to detect what stack is present.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Nice, but does it mean that are in use?

review: Needs Information
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/graphics_card_resource b/bin/graphics_card_resource
2index 962689e..5c7a61e 100755
3--- a/bin/graphics_card_resource
4+++ b/bin/graphics_card_resource
5@@ -124,7 +124,7 @@ def main():
6 try:
7 for index, record in enumerate(video_devices, 1):
8 record['index'] = index
9- if not subprocess.call(['dpkg-query', '-W', 'amdgpu-pro'],
10+ if not subprocess.call(['dpkg-query', '-W', 'vulkan-amdgpu-pro'],
11 stderr=subprocess.STDOUT,
12 stdout=subprocess.DEVNULL):
13 record['driver'] = 'amdgpu-pro'

Subscribers

People subscribed via source and target branches