Merge ~pieq/plainbox-provider-resource:fix_1581474 into plainbox-provider-resource:master

[Pierre Equoy]

In recent nl80211.h headers used in Xenial and Trusty (in package libnl-3-dev),
we have this:

enum nl80211_iftype {
 NL80211_IFTYPE_UNSPECIFIED,
 NL80211_IFTYPE_ADHOC,
 NL80211_IFTYPE_STATION,
 NL80211_IFTYPE_AP,
 NL80211_IFTYPE_AP_VLAN,
 NL80211_IFTYPE_WDS,
 NL80211_IFTYPE_MONITOR,
 NL80211_IFTYPE_MESH_POINT,
 NL80211_IFTYPE_P2P_CLIENT,
 NL80211_IFTYPE_P2P_GO,
 NL80211_IFTYPE_P2P_DEVICE,
 NL80211_IFTYPE_OCB,

 /* keep last */
 NUM_NL80211_IFTYPES,
 NL80211_IFTYPE_MAX = NUM_NL80211_IFTYPES - 1
};

NL80211_IFTYPE_OCB is new and means "Outside Context of a BSS".
On some devices, our program tries to access ifmodes[NL80211_IFTYPE_OCB],
which doesn't exist...

Before this fix is applied, when running the program on the test device:

-----------------------------------------
$ ./80211_resource
IBSS: supported
managed: supported
AP: supported
AP_VLAN: supported
WDS: supported
monitor: supported
mesh_point: supported
P2P_client: supported
P2P_GO: supported
Segmentation fault (core dumped)
-----------------------------------------

After:

-----------------------------------------
$ ./80211_resource
IBSS: supported
managed: supported
AP: supported
AP_VLAN: supported
WDS: supported
monitor: supported
mesh_point: supported
P2P_client: supported
P2P_GO: supported
outside_context_BSS: supported
n: supported
bg: supported
-----------------------------------------

This patch has been tested on both Trusty and Xenial.

[Sylvain Pineau (sylvain-pineau)]

What a good gdb session, well done. +1

review: Approve

diff --git a/src/80211_resource.c b/src/80211_resource.c
index df9d975..102a266 100644
--- a/src/80211_resource.c
+++ b/src/80211_resource.c
@@ -61,6 +61,7 @@ static const char *ifmodes[] = {
 	"P2P_client",
 	"P2P_GO",
 	"P2P_device",
+	"outside_context_BSS",
 };
 
 #define BIT(x) (1ULL<<(x))