Merge ~pieq/plainbox-provider-checkbox:1655211-graphics-driver into plainbox-provider-checkbox:master

Proposed by Pierre Equoy
Status: Merged
Approved by: Pierre Equoy
Approved revision: a08145450b513607f44ee0cc6749483c8265be5e
Merged at revision: 4802d760e6db284646173113808e30a45d7d6e5a
Proposed branch: ~pieq/plainbox-provider-checkbox:1655211-graphics-driver
Merge into: plainbox-provider-checkbox:master
Diff against target: 21 lines (+5/-2)
1 file modified
bin/graphics_driver (+5/-2)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+316537@code.launchpad.net

Description of the change

Update graphics_driver script to handle Matrox cards

One of the devices being tested uses a Matrox card. This card is using a kernel mode setting (kms) driver called 'modesetting' to work, but this use case was not handled in our graphics_driver script that displays information about drivers currently in use.

Please note: we still don't take the 'mga' user space driver into account since 'mga' is a legacy driver that is most likely not used anymore (Matrox now focuses on using modesetting).

To test, you can use an Xorg.0.log file from the device such as [1].

Before:

% ./graphics_driver
------------- VIDEO DRIVER INFORMATION -------------
ERROR: No video driver loaded! Possibly in failsafe mode!
(…)

After:

% ./graphics_driver
------------- VIDEO DRIVER INFORMATION -------------
Video Driver: modesetting
Driver Version: 1.18.4
(…)

[1] https://i302900887.restricted.launchpadlibrarian.net/302900887/Xorg.0.log?token=Cbff9BG2NKR2G07LNgG4Nxv5f51pnrGW

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Looks good! +1

// Matrox - I haven't seen that name in a while :D

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/graphics_driver b/bin/graphics_driver
2index e1b6abd..dfb5522 100755
3--- a/bin/graphics_driver
4+++ b/bin/graphics_driver
5@@ -183,11 +183,14 @@ class XorgLog(object):
6
7 # EDID and Modelines
8 # We use this part to determine which driver is in use
9- # For Intel / RADEON
10+ # For Intel / RADEON / Matrox (using modesetting)
11 m = re.search(r'\(II\) (.*)\(\d+\): EDID for output (.*)', line)
12 if m:
13 self.displays[display_name] = display
14- self.video_driver = m.group(1)
15+ if m.group(1) == "modeset":
16+ self.video_driver = "modesetting"
17+ else:
18+ self.video_driver = m.group(1)
19 display_name = m.group(2)
20 display = {'Output': display_name}
21 continue

Subscribers

People subscribed via source and target branches