Merge ~pieq/plainbox-provider-certification-server/+git/packaging:add-plainbox-packaging-metadata-support into ~checkbox-dev/plainbox-provider-certification-server/+git/packaging:master

[Pierre Equoy]

Add support for Plainbox packaging metadata

Packaging now relies on metadata described in the Server provider directly to determine package dependencies.

Please check the package built from this in my personal PPA:

https://launchpad.net/~pierre-equoy/+archive/ubuntu/ppa/+sourcepub/7497820/+listing-archive-extra

The generated control file looks like this:

----------------------------------------
Package: plainbox-provider-certification-server
Version: 0.32.0-0~2017020822482~ubuntu16.04.1
Architecture: all
Maintainer: Ubuntu Developers <email address hidden>
Installed-Size: 87
Depends: plainbox-provider-checkbox (>= 0.27~), iperf3, genisoimage, fwupdate, numactl, bc
Recommends: bonnie++, canonical-certification-submit, cpu-checker, fwts (>= 16.02.00-0ubuntu1~), iperf, ipmitool, nmap, plainbox-insecure-policy, qemu-system, qemu-utils, ssh, stress, stress-ng
Section: utils
Priority: optional
Description: Server Certification provider for Plainbox
 This package provides a test set of test plans that are used by Canonical
 for the testing and certification of "server" devices.
 .
 The actual tests (also known as plainbox jobs) are sourced from checkbox and
 plainbox resource providers. This package only contains the test plans
 themselves.
----------------------------------------

Please note that the `bc` package is in the Depends section because it was defined like this in the plainbox packaging metadata unit [1]

[1] https://git.launchpad.net/plainbox-provider-certification-server/tree/units/packaging.pxu#n24

[Sylvain Pineau (sylvain-pineau)]

+1, thanks for the cleanup (bc, genisoimage, iperf3)

review: Approve

diff --git a/debian/control b/debian/control
index 50f2179..fa79c26 100644
--- a/debian/control
+++ b/debian/control
@@ -8,20 +8,19 @@ Build-Depends: debhelper (>= 9.2),
                plainbox (>= 0.27~),
                plainbox-provider-resource-generic (>= 0.25~),
                python3-all (>= 3.2),
+               python3-debian,
                python3-setuptools
 Vcs-Git: git://git.launchpad.net/plainbox-provider-canonical-certification
 
 Package: plainbox-provider-certification-server
 Architecture: all
-Depends: plainbox-provider-checkbox (>= 0.27~)
-Recommends: bc,
-            bonnie++,
+Depends: plainbox-provider-checkbox (>= 0.27~),
+         ${plainbox:Depends}
+Recommends: bonnie++,
             canonical-certification-submit,
             cpu-checker,
             fwts (>=16.02.00-0ubuntu1~),
-            genisoimage,
             iperf,
-            iperf3,
             ipmitool,
             nmap,
             plainbox-insecure-policy,
@@ -29,7 +28,10 @@ Recommends: bc,
             qemu-utils,
             ssh,
             stress,
-            stress-ng
+            stress-ng,
+            ${plainbox:Recommends}
+Suggests: ${plainbox:Suggests}
+X-Plainbox-Provider: yes
 Description: Server Certification provider for Plainbox
  This package provides a test set of test plans that are used by Canonical
  for the testing and certification of "server" devices.
diff --git a/debian/rules b/debian/rules
index cfba8c3..8015df9 100755
--- a/debian/rules
+++ b/debian/rules
@@ -34,3 +34,7 @@ override_dh_auto_install:
 	# But don't modify the name, it has to be exactly as before
 	sed -i -e 's!name = $(terse_id)!name = $(verbose_id)!g' \
 		debian/tmp/usr/share/plainbox-providers-1/$(terse_id).provider
+
+override_dh_gencontrol:
+	python3 manage.py packaging
+	dh_gencontrol