Merge ~pieq/oem-qa-autosummary:fix-1945724-image-url into oem-qa-autosummary:master
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Pierre Equoy | ||||
Approved revision: | 81acbf987a25a4bc243f829afc1be65b7fb77aec | ||||
Merged at revision: | 1339810a70127fd5baa8db7bd4387da1bba39f06 | ||||
Proposed branch: | ~pieq/oem-qa-autosummary:fix-1945724-image-url | ||||
Merge into: | oem-qa-autosummary:master | ||||
Diff against target: |
172 lines (+35/-28) 4 files modified
autosummary/summary.py (+28/-21) webapp/__init__.py (+3/-3) webapp/static/style.css (+1/-1) webapp/templates/image_info.html (+3/-3) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nara Huang (community) | Approve | ||
StanleyHuang | Approve | ||
Review via email:
|
Description of the change
See issue lp:1945724 for more context.
With this MR, if auto-summary cannot find the mail.content file that contains the image name and the image sha256, it will ask user to manually enter the full URL to that image, and use it to compute the WebDAV URI to download the associated sha256 file that contains the image sha256 value.
This is a bit more flexible than the current situation where user can only input the image name, and not the URL.
To see it in action, check the following screen recording:
https:/
1. The carlsbad project is selected, with the x03 milestone.
2. The mail.content file cannot be found, so user manually inputs full URL to the image name
3. The webapp computes the WebDAV URI to point to the file containing the sha256 value and use it in the generated summary.
NOTE: In the above video, I use the x03 milestone, but then paste the URL to a x02 milestone image. This is for demonstration purpose only, because the x03 milestone for that project is actually not out yet.
LGTM +1