Merge ~pieq/oem-qa-autosummary:fix-1929019-double-quote into oem-qa-autosummary:master
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Pierre Equoy | ||||
Approved revision: | bb9880a5ee1ba40d5b7bdfd13fb2b136b1972ddb | ||||
Merged at revision: | 7d463e3e3784c08873530da059b7e609f1b6ecdb | ||||
Proposed branch: | ~pieq/oem-qa-autosummary:fix-1929019-double-quote | ||||
Merge into: | oem-qa-autosummary:master | ||||
Diff against target: |
121 lines (+54/-16) 4 files modified
README.md (+1/-1) tests/test_webapp.py (+35/-0) webapp/__init__.py (+16/-13) webapp/templates/summary.html (+2/-2) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nara Huang (community) | Approve | ||
Review via email:
|
Description of the change
Cleaned up some helper functions, one of which was creating a bug when generating summaries that contained bugs with double quotes in their titles.
In the process, I rewrote two help functions and added unit tests for them.
Test done:
A. Current version
------------------
1. Run the current version of autosummary
2. Find a project that can be used to generate an autosummary (I used Havana gm3-uc20 milestone)
3. Find a bug in that project that would be displayed in the generated summary
4. Update the title of that bug to include some double quotes ("blabla")
5. Generate the summary
→ The title of the chosen bug is truncated or even completely empty
B. Version in this MR
-------
1. Run it locally
2. Find a project that can be used to generate an autosummary (I used Havana gm3-uc20 milestone)
3. Find a bug in that project that would be displayed in the generated summary
4. Update the title of that bug to include some double quotes ("blabla")
5. Generate the summary
→ The title appears as expected
C. Run unit tests with version in this MR
-------
(venv)$ python -m unittest discover -s tests -v
ERROR:root:the mail.content file is not found on the WebDAV server
ERROR:root:
test_get_
test_get_
Test datetimes can be retrieved from image names ... ok
test_bug_link (test_webapp.
Test bug links can be generated as expected ... ok
test_bug_title (test_webapp.
Test bug title can be generated as expected ... ok
-------
Ran 4 tests in 0.004s
OK
LGTM +1