Merge lp:~pieq/checkbox/fix-1630525-graphics_card_resource-driver-name into lp:checkbox
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | 4518 |
Merged at revision: | 4519 |
Proposed branch: | lp:~pieq/checkbox/fix-1630525-graphics_card_resource-driver-name |
Merge into: | lp:checkbox |
Diff against target: |
12 lines (+2/-0) 1 file modified
providers/plainbox-provider-resource-generic/bin/graphics_card_resource (+2/-0) |
To merge this branch: | bzr merge lp:~pieq/checkbox/fix-1630525-graphics_card_resource-driver-name |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sylvain Pineau | Approve | ||
Review via email: mp+307804@code.launchpad.net |
Description of the change
A graphics card should always have a driver associated to it to work.
In lp:1630525 we discovered it was apparently not always the case, so udev will not return any driver name for the given graphics card.
We decided to fake it to avoid Checkbox to crash later, when trying to retrieve the information to use in template jobs.
To test, you can use the fact that the graphics_
(on a device with Checkbox available or using a virtualenv with Checkbox:)
./udev_resource > /tmp/udevres.log
vim /tmp/udevres.log # Edit the file to remove the graphics card driver information from the udev output
./graphics_
You should see something like:
bus: pci
category: VIDEO
→ driver: unknown ←
index: 1
path: /devices/
product: Xeon E3-1200 v3/4th Gen Core Processor Integrated Graphics Controller
product_id: 1042
product_slug: Xeon_E3-
subproduct_id: 34100
subvendor_id: 4163
vendor: Intel Corporation
vendor_id: 32902
vendor_slug: Intel_Corporation
+1, perfect!