~pieq/bugit/+git/qabro:fix-lp1782526-acpidump

Last commit made on 2018-07-27
Get this branch:
git clone -b fix-lp1782526-acpidump https://git.launchpad.net/~pieq/bugit/+git/qabro
Only Pierre Equoy can upload to this branch. If you are Pierre Equoy please log in for upload directions.

Branch merges

Branch information

Name:
fix-lp1782526-acpidump
Repository:
lp:~pieq/bugit/+git/qabro

Recent commits

61f9e1a... by Pierre Equoy

Add acpidump attachment

LP: #1782526

4090a54... by PMR <pmr@pmr-lander>

Merge #349789 from ~pieq/qabro/+git/qabro:add-fwts-logs

5844c4f... by Pierre Equoy

Bump to v0.7dev

be1cdfd... by Pierre Equoy

Add FWTS attachment when submitting Firmware-related issue

When filing a Firmware bug (i.e. a bug with a 'hwe-firmware' tag), Firmware
Test Suite (FWTS) needs to be launched and its logs attached to the issue.

For this, fwts needs to be snapped with qabro, and we need to pass the proper
LD_LIBRARY_PATH not only to qabro (as seen in the snapcraft.yaml file), but
also to the fwts command run by qabro.

The list of FWTS tests to be run is taken from the "recommended list" in the
FWTS script
<https://github.com/alexhungce/script-fwts/blob/master/recommend_fwts.sh>.

LP: #1781138

f6ba7a4... by Pierre Equoy

Cleanup unused script

4d4f779... by Pierre Equoy

Better check for need to attach checkbox session

da951ea... by PMR <pmr@pmr-lander>

Merge #349245 from ~pieq/qabro/+git/qabro:fix-merge-349029

3d9f914... by Pierre Equoy

Clean up subprocess calls and tidy up starting logic

The main purpose of this commit is to follow recommendations from Maciek in
merge request <https://code.launchpad.net/~pieq/qabro/+git/qabro/+merge/349029>

It replaces all the subprocess calls using insecure `shell=True` with something
more appropriate but that yields the same result.

In addition, extra caution steps are taken to handle subprocess calls if no
$PATH is defined.

18de24c... by Pierre Equoy

Bump to v0.6

42eccba... by PMR <pmr@pmr-lander>

Merge #349110 from ~pieq/qabro/+git/qabro:fix-bug-updating