Merge ~pieq/bugit/+git/qabro:fix-alsa-utils-service-dangling-symlink into bugit:master

[Pierre Equoy]

This MR fixes a bunch of warnings during snap build, but most importantly, allows to pass the snap store review properly.

My previous attempt to fix this[1] was wrong, because I removed the symlink in the wrong part.

This time, I made sure it actually worked by locally testing that the snap review would pass, by installing the review-tools snap and running

$ review-tools.snap-review qabro_0.15dev_amd64.snap
qabro_0.15dev_amd64.snap: pass

[1] https://code.launchpad.net/~pieq/qabro/+git/qabro/+merge/402186

[Patrick Liu (patliu)]

+1

review: Approve

diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index 94ffc39..8a509f3 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -8,7 +8,7 @@ base: core18
 
 apps:
   qabro:
-    command: qabro
+    command: usr/bin/python3 $SNAP/bin/qabro
     environment:
       GI_TYPELIB_PATH: $SNAP/usr/lib/$SNAPCRAFT_ARCH_TRIPLET/girepository-1.0
       LD_LIBRARY_PATH: $LD_LIBRARY_PATH:$SNAP/lib/fwts:$SNAP/lib/$SNAPCRAFT_ARCH_TRIPLET
@@ -16,16 +16,16 @@ apps:
       LC_ALL: C.UTF-8
 
   sosreport:
-    command: sosreport --no-report --batch --tmp-dir $SNAP_USER_COMMON -z gzip
+    command: usr/bin/python3 $SNAP/usr/bin/sosreport --no-report --batch --tmp-dir $SNAP_USER_COMMON -z gzip
 
   lspci:
-    command: lspci
+    command: usr/bin/lspci
 
   lsusb:
-    command: lsusb
+    command: usr/bin/lsusb
 
   amixer:
-    command: amixer
+    command: usr/bin/amixer
 
 parts:
   qabro:
@@ -91,13 +91,14 @@ parts:
     plugin: nil
     stage-packages:
       - alsa-utils
+      - libslang2
+    stage:
+      - -lib/systemd/system/alsa-utils.service
 
   acpidump:
     plugin: nil
     stage-packages:
       - acpica-tools
-    stage:
-      - -lib/systemd/system/alsa-utils.service
 
   dmsetup:
     plugin: nil