Merge ~pieq/bugit/+git/qabro:fix-snapstore-scan-failure-alsa-utils.service into bugit:master

Proposed by Pierre Equoy
Status: Merged
Approved by: Pierre Equoy
Approved revision: 75c64aaaaf09cb59311b8c8911fba5042ce4b605
Merged at revision: 93aa0275ba4113cd71e01b1574b2d202b4b58d18
Proposed branch: ~pieq/bugit/+git/qabro:fix-snapstore-scan-failure-alsa-utils.service
Merge into: bugit:master
Diff against target: 13 lines (+2/-0)
1 file modified
snap/snapcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Patrick Liu (community) Approve
OEM Services QA Pending
Review via email: mp+402186@code.launchpad.net

Description of the change

Snap store emits the following error e-mail:

Launchpad uploaded this snap package to the store, but the store failed to
scan it:

  package contains external symlinks: lib/systemd/system/alsa-utils.service

After looking around, it seems the acpidump package modified something in its packaging to point to this alsa-utils.service. I removed it by following the tips in this thread:

https://forum.snapcraft.io/t/store-unable-to-accept-contains-external-symlinks-to-sudo-service/23269

Before applying this patch, if you run snapcraft, you will see:

(...)
Building acpidump
+ snapcraftctl build
'lib/systemd/system/alsa-utils.service' will be a dangling symlink
(...)

After applying the patch, there is no more warning message.

To post a comment you must log in.
Revision history for this message
Patrick Liu (patliu) wrote :

+1 LGTM

review: Approve
Revision history for this message
Pierre Equoy (pieq) wrote :

Thanks! I rebased and will now merge this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index a7608a5..94ffc39 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -96,6 +96,8 @@ parts:
6 plugin: nil
7 stage-packages:
8 - acpica-tools
9+ stage:
10+ - -lib/systemd/system/alsa-utils.service
11
12 dmsetup:
13 plugin: nil

Subscribers

People subscribed via source and target branches

to all changes: