Merge ~pieq/bugit/+git/qabro:fix1840746-project-and-tags-arguments into bugit:master

[Pierre Equoy]

See lp:1840746 for more information.

Tested by creating a snap and launching:

$ APPORT_LAUNCHPAD_INSTANCE=staging qabro
$ APPORT_LAUNCHPAD_INSTANCE=staging qabro --fwts -p somerville -t test1
$ APPORT_LAUNCHPAD_INSTANCE=staging qabro --project qabro --tags "one two three"

[Maciej Kisielewski (kissiel)]

One big code simplification idea below.

[Pierre Equoy (pieq)]

Thanks for the feedback! Great idea indeed. This let me experiment with something I hadn't thought about before:

>>> def blabla(arg1='', arg2=''):
... print(arg1.lower(), arg2.upper())
...
>>> blabla()

>>> blabla('BLAAAA!', 'blaaAaaA')
blaaaa! BLAAAAAA
>>> blabla(None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 2, in blabla
AttributeError: 'NoneType' object has no attribute 'lower'

Passing "None" is actually passing something! :)

Anyway, I went with using argparse's argument_default, it should be alright.

review: Needs Resubmitting

[Pierre Equoy (pieq)]

@Maciek: Do you think this can be landed now?

[Maciej Kisielewski (kissiel)]

@Pierre: yessir!
+1

review: Approve

diff --git a/README b/README
index 6757ba7..e981bec 100644
--- a/README
+++ b/README
@@ -38,3 +38,9 @@ You can also use QABRO to automatically file Launchpad issues for the HWE team
 regarding FWTS-related issues. To do so:
 
 $ qabro --fwts -p <project> -t <platform-tag>
+
+It is also possible to pre-fill the Project and Tags sections when calling
+qabro; for instance, to open an issue in project "checkbox-ng" with tags
+"ce-qa-concern", "audio" and "hdmi":
+
+$ qabro -p checkbox-ng -t "ce-qa-concern audio hdmi"
diff --git a/qabro/__init__.py b/qabro/__init__.py
index 9c72446..85920c0 100644
--- a/qabro/__init__.py
+++ b/qabro/__init__.py
@@ -39,27 +39,26 @@ def main():
     epilog = ("Example: `qabro --fwts -p somerville -t platform-tag-3` will "
               "automatically open a Launchpad issue in the somerville project "
               "for the FWTS team.")
-    parser = argparse.ArgumentParser(epilog=epilog)
+    parser = argparse.ArgumentParser(epilog=epilog, argument_default='')
     parser.add_argument("--fwts", help=("Automatically files an issue in "
                                         "Launchpad for the firmware team"),
                         action="store_true")
     parser.add_argument("-p", "--project", help="Project name")
-    parser.add_argument("-t", "--tags", help="Tags (such as Platform tag)")
+    parser.add_argument("-t", "--tags",
+                        help="Tags (such as Platform tag) separated by spaces")
     args = parser.parse_args()
     if args.fwts:
         if not args.project:
             sys.exit("You must specify a project name, e.g -p somerville")
         if not args.tags:
             sys.exit("You must specify a platform tag, e.g. -t platform-tag-3")
-        project = args.project.lower()
-        tags = args.tags.lower()
         auto_submit_fwts_report(project, tags)
     else:
-        start_ui()
+        start_ui(project=args.project, tags=args.tags)
 
 
-def start_ui():
-    ui = ReportScreen()
+def start_ui(project='', tags=''):
+    ui = ReportScreen(project=project.lower(), tags=tags.lower())
     ui.run()
     ba = BugAssistant(ui.report())
     while True:
diff --git a/qabro/ui.py b/qabro/ui.py
index 9303cc9..930a1e3 100644
--- a/qabro/ui.py
+++ b/qabro/ui.py
@@ -52,7 +52,7 @@ class ReportScreen:
                            "[Actual result]\n\n"
                            "[Failure rate]\n\n")
 
-    def __init__(self):
+    def __init__(self, project='', tags=''):
         # Adding standard info (CPU, BIOS, GPU, etc.)  to the description
         std_info = AttachmentAssistant.get_standard_info()
         std_info_str = '\n'.join(['{}: {}'.format(elt, std_info[elt]) for elt in std_info])
@@ -62,7 +62,7 @@ class ReportScreen:
         self._description = urwid.LineBox(urwid.Edit(edit_text=self.default_description,
                                           multiline=True),
                                           "Description (including steps to reproduce)")
-        self._project = urwid.LineBox(urwid.Edit(), 'Project')
+        self._project = urwid.LineBox(urwid.Edit(edit_text=project), 'Project')
         self._series = urwid.LineBox(urwid.Edit(), 'Series')
         self._status = []
         for s in self.statuses:
@@ -75,7 +75,7 @@ class ReportScreen:
             rb = urwid.RadioButton(self._bug_type, i, state=False,
                                    on_state_change=self.add_tag)
         self._assignee = urwid.LineBox(urwid.Edit(), 'Assigned To (Launchpad ID)')
-        self._tags = urwid.LineBox(urwid.Edit(), 'Tags')
+        self._tags = urwid.LineBox(urwid.Edit(edit_text=tags), 'Tags')
         status_list = urwid.LineBox(urwid.Pile(self._status), 'Status')
         importance_list = urwid.LineBox(urwid.Pile(self._importance), 'Importance')
         bug_types_list = urwid.LineBox(urwid.Pile(self._bug_type), 'Bug Type')