Merge ~pieq/bugit/+git/qabro:add-fwts-logs into bugit:master
Proposed by
Pierre Equoy
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Pierre Equoy | ||||
Approved revision: | 5844c4f9ae6a8f0c53ff3278dc5dd477823c9be7 | ||||
Merged at revision: | 4090a540e0eb2298f27f0b7ee80d9b78bbc1521d | ||||
Proposed branch: | ~pieq/bugit/+git/qabro:add-fwts-logs | ||||
Merge into: | bugit:master | ||||
Diff against target: |
144 lines (+54/-16) 5 files modified
dev/null (+0/-10) qabro/__version__.py (+1/-1) qabro/bug_assistant.py (+23/-2) qabro/ui.py (+2/-1) snap/snapcraft.yaml (+28/-2) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Maciej Kisielewski (community) | Approve | ||
Review via email:
|
Description of the change
To test:
- build a snap out of it:
snapcraft cleanbuild
- install in devmode:
snap install qabro_0.
- launch on Launchpad Staging instance:
APPORT_
- fill the proper info, and select "Firmware" as issue type (or at least, make sure there is a `hwe-firmware` tag)
→ this should create an issue with fwts logs attached
Tested on 18.04 desktop and UC16.
To post a comment you must log in.
I need some explanation why FWTS has to be built afresh when snapping.
Also one nitpick inline.