Merge ~pieq/bugit/+git/qabro:better-bug-creation-and-error-handling into bugit:master

[Pierre Equoy]

See commit description for more info.

To test, you can use a small python script:

-----
#!/usr/bin/env python
import qabro

qabro.main()
-----

To trigger an error (and therefore to check the "bug update" feature), try to create an issue in the "qa-candidate" project (it's a test project owned by Jerry) with importance set to "Critical" (only Jerry can set importance, so this should trigger the error).

[Pierre Equoy (pieq)]

Self-approved

review: Approve

diff --git a/qabro/bug_assistant.py b/qabro/bug_assistant.py
index c2a3927..782b11a 100644
--- a/qabro/bug_assistant.py
+++ b/qabro/bug_assistant.py
@@ -38,6 +38,8 @@ class BugAssistant:
 
     def __init__(self, bug_report):
         self.update(bug_report)
+        # Launchpad bug, in case something is wrong after creating the bug
+        self.bug = None
 
     def update(self, bug_report):
         self.lp_title = bug_report.title
@@ -93,11 +95,9 @@ class BugAssistant:
             print('Checking project name...')
             project = launchpad.projects[self.lp_project]
             #logging.debug('Project found: {0}'.format(project))
-        except Exception as exception:
-            #logging.error(exception)
+        except Exception as ex:
             error_message = ('{} launchpad project not found'
                              .format(self.lp_project))
-            #logging.error(error_message)
             raise BugAssistantError(error_message)
 
         series_name = self.lp_series
@@ -117,31 +117,36 @@ class BugAssistant:
             try:
                 print('Checking assignee...')
                 assignee = launchpad.people[assignee_name]
-            except Exception as exception:
-                #logging.error(exception)
+            except Exception as ex:
                 error_message = ('{} launchpad user not found'
                                  .format(assignee_name))
-                #logging.error(error_message)
                 raise BugAssistantError(error_message)
 
-        print('Creating Launchpad bug report...')
         std_info = AttachmentAssistant.get_standard_info()
         std_info_str = '\n'.join(['{}: {}'.format(elt, std_info[elt])
                                   for elt in std_info])
         description = self.lp_description + "\n\n-----\n\n" + std_info_str
-        bug = launchpad.bugs.createBug(title=self.lp_title,
-                                       description=description,
-                                       tags=self.lp_tags.split(),
-                                       target=project)
+        if not self.bug:
+            print('Creating Launchpad bug report...')
+            self.bug = launchpad.bugs.createBug(title=self.lp_title,
+                                           description=description,
+                                           tags=self.lp_tags.split(),
+                                           target=project)
+            print('Bug report #{} created.'.format(self.bug.id))
+        else:
+            print('Updating Launchpad bug report...')
+            self.bug.title = self.lp_title
+            self.bug.description = description
+            tags = self.lp_tags.split()
+            target = project
+            self.bug.lp_save()
+
         if series:
-            nomination = bug.addNomination(target=series)
+            nomination = self.bug.addNomination(target=series)
             nomination.approve()
 
-        #logging.debug('Bug created: {0}'.format(bug))
-        self.bug = bug
-
         # Task configuration
-        task = bug.bug_tasks[0]
+        task = self.bug.bug_tasks[0]
         print('Setting status...')
         task.status = self.lp_status
         print('Setting importance...')
@@ -154,18 +159,18 @@ class BugAssistant:
 
         if ('APPORT_STAGING' in os.environ
             or os.environ.get('APPORT_LAUNCHPAD_INSTANCE', None) == 'staging'):
-            bug_url = STAGING_WEB_ROOT+'bugs/{}'.format(bug.id)
+            bug_url = STAGING_WEB_ROOT+'bugs/{}'.format(self.bug.id)
         else:
-            bug_url = LPNET_WEB_ROOT+'bugs/{}'.format(bug.id)
+            bug_url = LPNET_WEB_ROOT+'bugs/{}'.format(self.bug.id)
 
-        print('Bug report #{} created.'.format(bug.id))
+        print('Bug report #{} updated.'.format(self.bug.id))
 
         print('Uploading bug data...')
         aa = AttachmentAssistant(self.options)
         aa.run_attachment_methods()
-        aa.upload_attachments(launchpad, bug.id)
+        aa.upload_attachments(launchpad, self.bug.id)
 
-        return 'Bug report #{} and it attachments are available at <{}>'.format(bug.id, bug_url)
+        return 'Bug report #{} and it attachments are available at <{}>'.format(self.bug.id, bug_url)
 
 
 class BugAssistantError(Exception):