Merge ~pieq/bugit/+git/qabro:no-sudo-needed into bugit:master

[Pierre Equoy]

[Pierre Equoy (pieq)]

Self-approved

review: Approve

[Maciej Kisielewski (kissiel)]

This is a non-trivial patch that got self-approved the same day it got proposed. And it's hard for me to see the reason to rush it that hard, especially when I consider it being of sub-perfect quality. See diff comments for details.

review: Needs Fixing

diff --git a/qabro/__init__.py b/qabro/__init__.py
index 83c6b75..b0bcdb3 100644
--- a/qabro/__init__.py
+++ b/qabro/__init__.py
@@ -7,21 +7,25 @@ from bug_assistant import BugAssistant
 from ui import ReportScreen
 
 def main():
-    snap_name = os.getenv('SNAP_NAME')
-    code = subprocess.call('snap list {} | grep devmode'.format(snap_name),
-                           stdout=subprocess.PIPE,
-                           stderr=subprocess.PIPE,
-                           shell=True
-                          )
-    if code == 0:
-        logfile = os.path.join(os.getenv('SNAP_USER_COMMON'), 'qabro.log')
-        logging.basicConfig(filename=logfile,
-                            format='%(asctime)s - %(levelname)s - %(message)s',
-                            level=logging.ERROR
-                           )
-        start_ui()
+    if os.getenv('SUDO_USER'):
+        sys.exit(("This tool does not need to be run as super user. "
+                  "Please run it again without `sudo`."))
     else:
-        sys.exit("This tool requires --devmode option to run properly.")
+        snap_name = os.getenv('SNAP_NAME', 'qabro')
+        code = subprocess.call('snap list {} | grep devmode'.format(snap_name),
+                               stdout=subprocess.PIPE,
+                               stderr=subprocess.PIPE,
+                               shell=True
+                              )
+        if code == 0:
+            logfile = os.path.join(os.getenv('SNAP_USER_COMMON', '/tmp'), 'qabro.log')
+            logging.basicConfig(filename=logfile,
+                                format='%(asctime)s - %(levelname)s - %(message)s',
+                                level=logging.ERROR
+                               )
+            start_ui()
+        else:
+            sys.exit("This tool requires --devmode option to run properly.")
 
 def start_ui():
     ui = ReportScreen()