Merge lp:~piastucki/bzr-xmloutput/fix-399067-incorrect-paths-if-execute-bit-changed into lp:bzr-xmloutput

Proposed by Piotr Piastucki
Status: Merged
Approved by: Guillermo Gonzalez
Approved revision: 173
Merge reported by: Guillermo Gonzalez
Merged at revision: not available
Proposed branch: lp:~piastucki/bzr-xmloutput/fix-399067-incorrect-paths-if-execute-bit-changed
Merge into: lp:bzr-xmloutput
Diff against target: 26 lines (+6/-8)
1 file modified
statusxml.py (+6/-8)
To merge this branch: bzr merge lp:~piastucki/bzr-xmloutput/fix-399067-incorrect-paths-if-execute-bit-changed
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+179786@code.launchpad.net

Description of the change

xmlstatus returns incorrect file paths when permission bits are changed because it appends an '*' in this case - see https://bugs.launchpad.net/bzr-xmloutput/+bug/399067 for more details.
The fix introduce a new attribute called 'meta_modified' instead of changing the file path in statusxml.py.

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'statusxml.py'
2--- statusxml.py 2011-12-12 15:11:38 +0000
3+++ statusxml.py 2013-08-12 19:55:44 +0000
4@@ -271,16 +271,14 @@
5 path += '/'
6 elif kind == 'symlink':
7 path += '@'
8+ meta_modified = ''
9 if len(item) == 5 and item[4]:
10- path += '*'
11- if show_ids:
12- kind_id = ''
13- if fid:
14- kind_id = get_kind_id_element(kind, fid)
15- to_file.write('<%s %s>%s</%s>' % (kind, kind_id,
16+ meta_modified = ' meta_modified="true"'
17+ kind_id = ''
18+ if show_ids and fid:
19+ kind_id = ' ' + get_kind_id_element(kind, fid)
20+ to_file.write('<%s%s%s>%s</%s>' % (kind, kind_id, meta_modified,
21 _escape_cdata(path), kind))
22- else:
23- to_file.write('<%s>%s</%s>' % (kind, _escape_cdata(path), kind))
24
25 if delta.removed:
26 to_file.write('<removed>')

Subscribers

People subscribed via source and target branches

to all changes: