Merge lp:~phw/earcandy/fixes into lp:earcandy

Proposed by Philipp Wolfer
Status: Needs review
Proposed branch: lp:~phw/earcandy/fixes
Merge into: lp:earcandy
Diff against target: 14 lines (+4/-1)
1 file modified
ear_candy/Freedesktop.py (+4/-1)
To merge this branch: bzr merge lp:~phw/earcandy/fixes
Reviewer Review Type Date Requested Status
KillerKiwi looks good Approve
Review via email: mp+27755@code.launchpad.net
To post a comment you must log in.
Revision history for this message
KillerKiwi (killerkiwi2005) :
review: Approve (looks good)
Revision history for this message
Philipp Wolfer (phw) wrote :

Hi,

thanks for approving the fix. Unfortunately the merge request and review system on Launchpad is not really good and does not automatically perform the merges. Someone with write access to the lp:earcandy branch must perform the merge :(

Thanks,
Philipp

Unmerged revisions

81. By Philipp Wolfer

Fixed parsing of commands separated by semicolon from desktop files

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ear_candy/Freedesktop.py'
2--- ear_candy/Freedesktop.py 2009-06-03 20:26:47 +0000
3+++ ear_candy/Freedesktop.py 2010-06-16 19:20:41 +0000
4@@ -85,7 +85,10 @@
5 def get_exec_array(self):
6 command = []
7 p = re.compile("('[^']+')|(\"[^\"]+\")|([^\s]+)")
8- for r in re.finditer(p, self.get("Exec")):
9+ cmd = self.get("Exec")
10+ if isinstance(cmd, list):
11+ cmd = "; ".join(cmd)
12+ for r in re.finditer(p, cmd):
13 command.append( str(r.group(0)) )
14 return command
15

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: