Merge ~philroche/unminimize:bugfix/lp-2066905-no-longer-install-lxd-snap into unminimize:master

Proposed by Philip Roche
Status: Merged
Merged at revision: aa975bdd10b9e0e093b038af9b08f0657f1f521c
Proposed branch: ~philroche/unminimize:bugfix/lp-2066905-no-longer-install-lxd-snap
Merge into: unminimize:master
Diff against target: 33 lines (+6/-9)
2 files modified
debian/changelog (+6/-0)
unminimize (+0/-9)
Reviewer Review Type Date Requested Status
Utkarsh Gupta Approve
Paride Legovini (community) lgtm Approve
Simon Déziel (community) Approve
Review via email: mp+466383@code.launchpad.net

Commit message

fix: No longer install LXD snap in unminimize script (LP: #2066903)

The LXD snap is no longer seeded in any images since Noble+ so the LXD related
unminimize logic is no longer required.

lxd-installer can remain installed.

LP: #2066905 is the corresponding bug to address build related changes in livecd-rootfs

To post a comment you must log in.
Revision history for this message
Simon Déziel (sdeziel) wrote :

LGTM, thanks

review: Approve
Revision history for this message
Paride Legovini (paride) :
review: Approve (lgtm)
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

$ dput ubuntu ../unminimize_0.3_source.changes
Uploading unminimize using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running required-fields: check whether a field is present and non-empty in the changes file
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running check-debs: makes sure the upload contains a binary package
running gpg: check GnuPG signatures before the upload
Uploading unminimize_0.3.dsc
Uploading unminimize_0.3.tar.xz
Uploading unminimize_0.3_source.buildinfo
Uploading unminimize_0.3_source.changes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index c131c22..dd010a9 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+unminimize (0.3) UNRELEASED; urgency=medium
7+
8+ * No longer install LXD snap in unminimize script (LP: #2066903)
9+
10+ -- Philip Roche <phil.roche@canonical.com> Fri, 24 May 2024 12:14:38 +0100
11+
12 unminimize (0.2) noble; urgency=medium
13
14 * Fix licensing.
15diff --git a/unminimize b/unminimize
16index 627fda1..c0a2cf5 100755
17--- a/unminimize
18+++ b/unminimize
19@@ -105,14 +105,5 @@ if [ "$IMAGE_TYPE" = "ubuntu-cloud" ]; then
20 fi
21 fi
22
23-if [ "$IMAGE_TYPE" = "ubuntu-cloud" ] || [ "$IMAGE_TYPE" = "ubuntu-server" ]; then
24- # installing LXD using the lxd-installer by simply invoking it
25- echo "Invoking LXD so that it can be installed by the lxd-installer's script.."
26- lxd --version
27-
28- echo "Removing lxd installer package..."
29- apt-get purge -y lxd-installer
30-fi
31-
32 # unminimization succeeded, there is no need to mention it in motd
33 rm -f /etc/update-motd.d/60-unminimize

Subscribers

People subscribed via source and target branches

to all changes: