lp:~philroche/livecd-rootfs/+git/livecd-rootfs

Author: Philip Roche
Author Date: 2024-04-12 11:40:20 UTC

fix: Use Ubuntu policy default channel "latest" for preseeded snaps (LP: #2061121)

Recent Mantic cloud image builds fail after default track for LXD change to "5.21" instead of "latest"

This changes preseed from "latest/" for all snaps and no longer assume that "latest/" is the default.

Author: Philip Roche
Author Date: 2024-04-08 17:13:10 UTC

fix: Update d/ch for 24.04.59

This includes changes to address LP: #2060558

Author: Philip Roche
Author Date: 2024-04-02 10:11:56 UTC

fix: Update d/ch for 2.664.53 to include references to seed validation (LP: #2059730)

Add missing references to LP: #2059730.

Author: Philip Roche
Author Date: 2024-02-22 17:39:31 UTC

fix: Set the required debconf settings to allow for non interactive grub updates in cloud images (LP: #2054103)

As part of addressing LP: #2054103 [1] an update to grub-pc added a feature to be able to ensure that grub-pc
installation can happen noninteractively on cloud images.

This change is equivalent to running

```
debconf-set-selections grub-pc grub-efi/cloud_style_installation boolean true
debconf-set-selections grub-pc grub-pc/cloud_style_installation boolean true
```

These were introduced optionally to determine the install device using
`grub-probe` dynamically instead of having to fill the `grub-pc/install-devices`
debconf entry.

[1] https://bugs.launchpad.net/cloud-images/+bug/2054103

Author: Philip Roche
Author Date: 2024-02-16 12:33:28 UTC

feat: Update d/ch for 2.765.41

Add description for changes proposed in 2.765.41

(cherry picked from commit 8daf75cd35807afbfbfe2a2e0ef82b8f0b9bbd3e)

Author: Philip Roche
Author Date: 2024-02-16 12:33:28 UTC

feat: Update d/ch for 2.765.40

Add description for changes proposed in 2.765.40

(cherry picked from commit b97a2133134f0f2a7ae3e3b1d8ced6f81c4b0cb9)

Author: Philip Roche
Author Date: 2024-02-16 12:33:28 UTC

feat: Update d/ch for 2.765.39

Add description for changes proposed in 2.765.39

Author: Philip Roche
Author Date: 2024-02-09 10:31:38 UTC

Update d/ch for 2.664.50 release

(cherry picked from commit e51e89423d7551d1db82f3bd869867aa7eabb1a5)

# Conflicts:
# debian/changelog

Author: Philip Roche
Author Date: 2024-02-09 10:15:49 UTC

Update d/ch for 2.664.53 release

Author: Philip Roche
Author Date: 2024-01-24 17:58:46 UTC

fix: `return 0` instead of `return` if the intent is not to exit build

If the previous if statement checking if PASSES_TO_LAYERS is true,
then the last return code be non-zero and a return statement with no
argument will return the error code of the if statement thus exiting
the script. This is not our intent. So we need to return 0 here when
layer name as already been registered

Author: Philip Roche
Author Date: 2024-01-22 19:41:22 UTC

fix: Fix calls to `unminimize` if lxd-installer package not present (LP: #2049723)

The unminimize script will try to install the lxd snap using the shim script
`/usr/sbin/lxd` from the lxd-installer package.

Previously `unminimize` was using `snap`
to install `lxd` directly which was being diverted by diverting the `snap` command.

This is no longer the case so we can remove `/usr/sbin/lxd` from the lxd-installer package
if it exists and then redirect any calls to `/usr/sbin/lxd` to `/bin/true`

This is a cherry pick forward port from Jammy livecd-rootfs version 2.765.37.

(cherry picked from commit 8b83212372e0c1adb1dbdf7ead234f93c52a189e)

Author: Philip Roche
Author Date: 2024-01-22 12:48:55 UTC

fix: Always use `dpkg-divert` instead of altering files maintained by packages

Altering a file maintained by a package can lead to unexpected behaviou expecially in
this case where packages are being removed and added.

Instead use `dpkg-divert` to allow us to mock `lxd` to `true` to allow `unminimize` to work
without error and to avoid installing of the `lxd` snap.

Author: Thomas Bechtold
Author Date: 2024-01-19 08:39:31 UTC

Update d/changelog

(cherry picked from commit 373b5b633867b11f893758b2dc3f84a135fb8f59)

Author: Philip Roche
Author Date: 2023-12-04 12:47:24 UTC

fix: Mark grub-pc-bin as manual install to avoid autoremoval (LP: #2045418)

With amd64 build target calling `update-grub` no longer works and fails build with error

```
grub-install: error: /usr/lib/grub/i386-pc/modinfo.sh doesn't exist. Please specify --target or --directory.
```

`/usr/lib/grub/i386-pc/modinfo.sh` is part of the grub-pc-bin package.

We are seeing this now on xenial as grub-pc-bin is now removed during build as part of fixing
bug https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/2036195.

To resolve this we mark grub-pc-bin as manually installed so it is not autoremoved.

As we are running grub-install ourselves for a specific target we need to make sure to install that
target first which means this will not be solved by changing dependencies of the grub packages.

Author: Philip Roche
Author Date: 2023-10-11 10:45:29 UTC

fix: Enable snap preseeding with ppc64el images where /boot/vmlinux is used instead of /boot/vmlinuz. (LP: #2038957)

ppc64el still uses /boot/vmlinux so we need to determine the boot file name as non ppc64el use /boot/vmlinuz. This
is then used to determine the kernel major minor version installed so that the correct apparmor features can be used
during snap preseeding. This preseeding was failing for ppc64el for the mantic 6.5 kernel as the /boot/vmlinuz
being checked did not exist.

(cherry picked from commit 089646a32f927f32e9e8961e231391f0bcb6f66b)

# Conflicts:
# debian/changelog
# live-build/functions

Author: Philip Roche
Author Date: 2023-10-11 10:45:29 UTC

fix: Enable snap preseeding with ppc64el images where /boot/vmlinux is used instead of /boot/vmlinuz. (LP: #2038957)

ppc64el still uses /boot/vmlinux so we need to determine the boot file name as non ppc64el use /boot/vmlinuz. This
is then used to determine the kernel major minor version installed so that the correct apparmor features can be used
during snap preseeding. This preseeding was failing for ppc64el for the mantic 6.5 kernel as the /boot/vmlinuz
being checked did not exist.

Author: Steve Langasek
Author Date: 2023-09-17 00:27:45 UTC

The chroot tmpfs mount should only be /var/lib/apt/lists, not /var/lib/apt; the latter breaks changes to /var/lib/apt/extended_states. LP: #2036195.

(cherry picked from commit 1deccc2edd7f139b84a6cb3d0a4dfe5ebaff50c7)

# Conflicts:
# debian/changelog

Author: Steve Langasek
Author Date: 2023-09-17 00:27:45 UTC

The chroot tmpfs mount should only be /var/lib/apt/lists, not /var/lib/apt; the latter breaks changes to /var/lib/apt/extended_states. LP: #2036195.

(cherry picked from commit 1deccc2edd7f139b84a6cb3d0a4dfe5ebaff50c7)

# Conflicts:
# debian/changelog

Author: Steve Langasek
Author Date: 2023-09-17 00:27:45 UTC

The chroot tmpfs mount should only be /var/lib/apt/lists, not /var/lib/apt; the latter breaks changes to /var/lib/apt/extended_states. LP: #2036195.

(cherry picked from commit 1deccc2edd7f139b84a6cb3d0a4dfe5ebaff50c7)

# Conflicts:
# debian/changelog

Author: Steve Langasek
Author Date: 2023-09-17 00:27:45 UTC

The chroot tmpfs mount should only be /var/lib/apt/lists, not /var/lib/apt; the latter breaks changes to /var/lib/apt/extended_states. LP: #2036195.

(cherry picked from commit 1deccc2edd7f139b84a6cb3d0a4dfe5ebaff50c7)

# Conflicts:
# debian/changelog

Author: Steve Langasek
Author Date: 2023-09-17 00:27:45 UTC

The chroot tmpfs mount should only be /var/lib/apt/lists, not /var/lib/apt; the latter breaks changes to /var/lib/apt/extended_states. LP: #2036195.

(cherry picked from commit 1deccc2edd7f139b84a6cb3d0a4dfe5ebaff50c7)

# Conflicts:
# debian/changelog

Author: Philip Roche
Author Date: 2023-10-11 10:45:29 UTC

fix: Enable snap preseeding with ppc64el images where /boot/vmlinux is used instead of /boot/vmlinuz. (LP: #2038957)

ppc64el still uses /boot/vmlinux so we need to determine the boot file name as non ppc64el use /boot/vmlinuz. This
is then used to determine the kernel major minor version installed so that the correct apparmor features can be used
during snap preseeding. This preseeding was failing for ppc64el for the mantic 6.5 kernel as the /boot/vmlinuz
being checked did not exist.

Author: Philip Roche
Author Date: 2023-10-06 17:11:01 UTC

custom root squashfs to install util-linux

Author: Philip Roche
Author Date: 2023-10-02 10:50:30 UTC

fix: Only install lxd-agent-loader package in ubuntu-cpc qcow2 cloud images (LP: #2031921)

There are some packages that are not installed by default in the
disk-image that this binary is based on as the disk-image is used as
a base for all the derivatives. We should keep the number of packages
installed in the disk images that are not applicable to all derivatives to a
minimum and only install packages in images where they are required.
An example of one such package is lxd-agent-loader which
is only applicable to the qcow2 download images which are used for LXD VMs
via simplestreams. This specific example has details in LP#2031921.

This also sets -u to catch any unset variables now that this binary hook is
calling shared functions. One such variable was IMAGE_STR which is used in
the image mounting function `mount_disk_image`

Author: Philip Roche
Author Date: 2023-09-27 10:33:54 UTC

fix: arm flash-kernel removal from ubuntu-cpc project cloud images (LP: #2037074)

With the migration from linux-kvm to linux-virtual/generic for the mantic minimal
images we can now start building arm64 minimal cloud images.

When building initial test images we noticed that the flash-kernel package was being
installed. This is not required for EFI images.

This commit removes the flash-kernel package from the cloud images arm installs

The only images built using the livecd-rootfs ubuntu-cpc project for arm64 and armhf
which are not cloud images (which therefore do not require flash-kernel) are the
raspi images. raspi does require flash-kernel. But the raspi images use the
`ubuntu-server-raspi` task to install the flash-kernel. As such this non raspi
flash-kernel package install can be completely removed.

It also means that initramfs-tools and dracut-install are installed as these are dependencies
of flash-kernel package.

Author: Philip Roche
Author Date: 2023-09-26 16:28:25 UTC

fix: Ensure that grub/shim package installs do not install recommends for minimized ubuntu-cpc image builds (LP: #2037075)

minimized cloud image policy, introduced in version 23.10.16, is to not install recommends for any package
installs during build. This is to keep the image as small as possible. This also extends to
the grub related packages.

This solves the problems detailed in LP: #2037075 and aligns other arches more with amd64 install of
grub/shim packages for both minimized and non minimized ubuntu-cpc cloud image builds.

Author: Philip Roche
Author Date: 2023-09-22 11:28:18 UTC

fix: arm flash-kernel removal from minimal cloud images (ubuntu-cpc project) (LP: #2037074)

With the migration from linux-kvm to linux-virtual/generic for the mantic minimal
images we can now start building arm64 minimal cloud images.

When building initial test images we noticed that the flash-kernel package was being
installed. This is not required for EFI images.

This commit removes the flash-kernel package from the minimal cloud images arm installs

It also means that initramfs-tools and dracut-install are installed as these are dependencies
of flash-kernel package.

Author: Philip Roche
Author Date: 2023-09-22 10:59:00 UTC

fix: Install with recommends when installing grub/shim packages in arm ubuntu-cpc minimized images (LP: #2037075)

With the migration from linux-kvm to linux-virtual/genreic for the mantic minimal
images we can now start building arm64 minimal cloud images.

When building initial test images we noticed that when comparing the amd64 minimized images
and the arm64 images that the efibootmgr package was not installed in the arm64 images.

This is because for amd64 it is installed as a recommends of shim-signed but for arm64
we are installing shim-signed `--no-install-recommends`.

This commit ensures that we align more with amd64 install of grub/shim packages for arm
images and also install recommends packages.

For arm64 this ensures that efibootmgr is installed too.

Author: Philip Roche
Author Date: 2023-09-19 10:30:40 UTC

Update d/ch for 23.10.42 release

Author: Philip Roche
Author Date: 2023-09-15 10:36:26 UTC

fix: armhf flavour for 6.5+ kernel is now generic (LP: #2033677)

With the introduction of the 6.5 kernel for mantic on 13th September ago we are seeing image build failures
on the armhf builds. The build failure was `No kernel output for generic-lpae!`.

Introduced in the 6.4 kernel and therefore now also in 6.5 there is no generic-lpae flavor anymore. it's just generic now.

As such this commit updates the expected flavour for armhf to generic.

Author: Philip Roche
Author Date: 2023-09-15 10:59:06 UTC

fix: ensure minimize-manual script uses passed in argument for all commands (LP: #2036198)

minimize-manual takes an argument of the path to the chroot but of the 3 commands that are run the argument
is only used twice and with the third hardcoding "chroot" as the path to the chroot.

Thankfully "chroot" has been the patch passed in for the current uses of minimize-manual but this
could cause issues later if that were to change.

This commit resolves the problem preventing future issues.

Author: Philip Roche
Author Date: 2023-09-01 11:24:59 UTC

Update changelog for livecd-rootfs 23.10.31 (LP: #2033751)

Author: Philip Roche
Author Date: 2023-09-01 00:51:14 UTC

Imported 23.10.29 from mantic-release pocket.

No reason for CPC update specified.

Author: Philip Roche
Author Date: 2023-08-31 17:26:42 UTC

fix: Sort filelists creating when building ubuntu-cpc images (LP: #2033677)

The image filelists created during ubuntu-cpc project image builds were not sorted.

Soring the filelists makes it easier to compare the filelists without needing to sort first.

Author: Philip Roche
Author Date: 2023-08-17 11:41:46 UTC

fix: Only close LP bug once in changelog entry

Indent related fixes under same bug heading

Author: Philip Roche
Author Date: 2023-08-11 12:46:40 UTC

fix: Install required package fuse3 when preseeding snaps

fuse3 was previously installed through recommends but with minimized images we no longer install recommends packages.

It is only required when preseeding snaps so does not need to be present in all minimized images so does not
need to be in the cloud-minimal seed.

Author: Philip Roche
Author Date: 2023-05-08 15:01:19 UTC

fix: Continue to build lunar with CPC fork until upstream upate the lunar release of livecd-rootfs

An ubuntu/lunar upstream git branch is also required

Author: Philip Roche
Author Date: 2023-05-08 14:43:15 UTC

fix: Continue to build mantic with CPC fork until upstream push a mantic release of livecd-rootfs

Author: Philip Roche
Author Date: 2023-01-13 13:25:41 UTC

fix: use chroot preseed

Author: Philip Roche
Author Date: 2023-01-13 09:40:12 UTC

fix: Temporarily pin snapd preseeding to snap channel stable/2.57.x

There is a regression in snapd 2.58 with a fix being worked on @
https://github.com/snapcore/snapd/pull/12483. The regression was
that it was no longer possible to preseed snaps during cloud
image builds. The temporary workaround is to preseed snapd
from a downgraded channel "stable/2.57.x". To do this temporarily
we will carry a patch on CPC's fork of livecd-rootfs on all suites.

Once the fix to snapd snap is rolled out with a new 2.58.1
release then the "stable/2.57.x" will be removed and
all users with snapd from channel "stable/2.57.x" will
fall back to "stable" channel and be upgraded to 2.58.1.

Author: Philip Roche
Author Date: 2023-01-13 09:39:03 UTC

fix: Temporarily pin snapd preseeding to snap channel stable/2.57.x

There is a regression in snapd 2.58 with a fix being worked on @
https://github.com/snapcore/snapd/pull/12483. The regression was
that it was no longer possible to preseed snaps during cloud
image builds. The temporary workaround is to preseed snapd
from a downgraded channel "stable/2.57.x". To do this temporarily
we will carry a patch on CPC's fork of livecd-rootfs on all suites.

Once the fix to snapd snap is rolled out with a new 2.58.1
release then the "stable/2.57.x" will be removed and
all users with snapd from channel "stable/2.57.x" will
fall back to "stable" channel and be upgraded to 2.58.1.

Author: Philip Roche
Author Date: 2023-01-13 09:37:41 UTC

fix: Temporarily pin snapd preseeding to snap channel stable/2.57.x

There is a regression in snapd 2.58 with a fix being worked on @
https://github.com/snapcore/snapd/pull/12483. The regression was
that it was no longer possible to preseed snaps during cloud
image builds. The temporary workaround is to preseed snapd
from a downgraded channel "stable/2.57.x". To do this temporarily
we will carry a patch on CPC's fork of livecd-rootfs on all suites.

Once the fix to snapd snap is rolled out with a new 2.58.1
release then the "stable/2.57.x" will be removed and
all users with snapd from channel "stable/2.57.x" will
fall back to "stable" channel and be upgraded to 2.58.1.

Author: Philip Roche
Author Date: 2023-01-13 09:36:32 UTC

fix: Temporarily pin snapd preseeding to snap channel stable/2.57.x

There is a regression in snapd 2.58 with a fix being worked on @
https://github.com/snapcore/snapd/pull/12483. The regression was
that it was no longer possible to preseed snaps during cloud
image builds. The temporary workaround is to preseed snapd
from a downgraded channel "stable/2.57.x". To do this temporarily
we will carry a patch on CPC's fork of livecd-rootfs on all suites.

Once the fix to snapd snap is rolled out with a new 2.58.1
release then the "stable/2.57.x" will be removed and
all users with snapd from channel "stable/2.57.x" will
fall back to "stable" channel and be upgraded to 2.58.1.

Author: Philip Roche
Author Date: 2023-01-13 09:33:24 UTC

fix: Temporarily pin snapd preseeding to snap channel stable/2.57.x

There is a regression in snapd 2.58 with a fix being worked on @
https://github.com/snapcore/snapd/pull/12483. The regression was
that it was no longer possible to preseed snaps during cloud
image builds. The temporary workaround is to preseed snapd
from a downgraded channel "stable/2.57.x". To do this temporarily
we will carry a patch on CPC's fork of livecd-rootfs on all suites.

Once the fix to snapd snap is rolled out with a new 2.58.1
release then the "stable/2.57.x" will be removed and
all users with snapd from channel "stable/2.57.x" will
fall back to "stable" channel and be upgraded to 2.58.1.

Author: Philip Roche
Author Date: 2023-01-13 09:31:36 UTC

fix: Temporarily pin snapd preseeding to snap channel stable/2.57.x

There is a regression in snapd 2.58 with a fix being worked on @
https://github.com/snapcore/snapd/pull/12483. The regression was
that it was no longer possible to preseed snaps during cloud
image builds. The temporary workaround is to preseed snapd
from a downgraded channel "stable/2.57.x". To do this temporarily
we will carry a patch on CPC's fork of livecd-rootfs on all suites.

Once the fix to snapd snap is rolled out with a new 2.58.1
release then the "stable/2.57.x" will be removed and
all users with snapd from channel "stable/2.57.x" will
fall back to "stable" channel and be upgraded to 2.58.1.

Author: CloudBuilder
Author Date: 2023-01-11 04:48:18 UTC

Imported 2.796

No reason for CPC update specified.

Author: Philip Roche
Author Date: 2021-12-08 11:25:46 UTC

Bump UEFI disk image size for armhf to 3.5 GB LP:#1953609

Current impish builds fail with:
```
cp: error writing 'mountpoint/var/lib/snapd/snaps/snapd_14067.snap': No space left on device
cp: cannot create directory 'mountpoint/var/lib/snapd/ssl': No space left on device
```

This is a cherrypick backport from ubuntu/master

Author: Philip Roche
Author Date: 2021-12-08 09:19:48 UTC

Bump UEFI disk image size for armhf to 3.5 GB

Current impish builds fail with:
```
cp: error writing 'mountpoint/var/lib/snapd/snaps/snapd_14067.snap': No space left on device
cp: cannot create directory 'mountpoint/var/lib/snapd/ssl': No space left on device
```

This is a cherry pick backport from jammy

Author: Philip Roche
Author Date: 2020-05-18 16:06:08 UTC

Revert of initramfs package removal in KVM image (LP: #1880170)

It was reported and confirmed in LP bug #1875400
(https://bugs.launchpad.net/cloud-images/+bug/1875400) that on the public
KVM cloud image there exists a large list of packages marked for auto-removal.

This should never be the case on a released cloud image.

These packages are marked for auto-removal because in the KVM image binary hook
we removed both initramfs-tools and busybox-initramfs packages. Due to package
dependencies this also removed:

busybox-initramfs* cloud-initramfs-copymods* cloud-initramfs-dyn-netconf*
cryptsetup-initramfs* initramfs-tools* initramfs-tools-core* multipath-tools*
overlayroot* sg3-utils-udev* ubuntu-server*

But it did not remove all the packages that the above list depended on.
This resulted in all those packages being marked for auto-removal because they
were not manually installed nor did they have any manually installed packages
that depended on them.

The removal of initramfs-tools and busybox-initramfs was to avoid the
generation of initramfs in images that should boot initramfsless.

This requirement is obsolete now because the initramfsless boot handling
is now handled via setting GRUB_FORCE_PARTUUID in /etc/default/grub.d/40-force-partuuid.cfg.

In test images I have verified that GRUB_FORCE_PARTUUID is set and that
boot speeds have not regressed.

LP: #1880170

Author: Philip Roche
Author Date: 2020-05-22 12:37:22 UTC

Revert of initramfs package removal in KVM image (LP: #1880170)

It was reported and confirmed in LP bug #1875400
(https://bugs.launchpad.net/cloud-images/+bug/1875400) that on the public
KVM cloud image there exists a large list of packages marked for auto-removal.

This should never be the case on a released cloud image.

These packages are marked for auto-removal because in the KVM image binary hook
we removed both initramfs-tools and busybox-initramfs packages. Due to package
dependencies this also removed:

busybox-initramfs* cloud-initramfs-copymods* cloud-initramfs-dyn-netconf*
cryptsetup-initramfs* initramfs-tools* initramfs-tools-core* multipath-tools*
overlayroot* sg3-utils-udev* ubuntu-server*

But it did not remove all the packages that the above list depended on.
This resulted in all those packages being marked for auto-removal because they
were not manually installed nor did they have any manually installed packages
that depended on them.

The removal of initramfs-tools and busybox-initramfs was to avoid the
generation of initramfs in images that should boot initramfsless.

This requirement is obsolete now because the initramfsless boot handling
is now handled via setting GRUB_FORCE_PARTUUID in /etc/default/grub.d/40-force-partuuid.cfg.

In test images I have verified that GRUB_FORCE_PARTUUID is set and that
boot speeds have not regressed.

LP: #1880170

Author: Philip Roche
Author Date: 2020-05-18 16:06:08 UTC

Revert of initramfs package removal in KVM image (LP: #1875400)

It was reported and confirmed in LP bug #1875400
(https://bugs.launchpad.net/cloud-images/+bug/1875400) that on the public
KVM cloud image there exists a large list of packages marked for auto-removal.

This should never be the case on a released cloud image.

These packages are marked for auto-removal because in the KVM image binary hook
we removed both initramfs-tools and busybox-initramfs packages. Due to package
dependencies this also removed:

busybox-initramfs* cloud-initramfs-copymods* cloud-initramfs-dyn-netconf*
cryptsetup-initramfs* initramfs-tools* initramfs-tools-core* multipath-tools*
overlayroot* sg3-utils-udev* ubuntu-server*

But it did not remove all the packages that the above list depended on.
This resulted in all those packages being marked for auto-removal because they
were not manually installed nor did they have any manually installed packages
that depended on them.

The removal of initramfs-tools and busybox-initramfs was to avoid the
generation of initramfs in images that should boot initramfsless.

This requirement is obsolete now because the initramfsless boot handling
is now handled via setting GRUB_FORCE_PARTUUID in /etc/default/grub.d/40-force-partuuid.cfg.

In test images I have verified that GRUB_FORCE_PARTUUID is set and that
boot speeds have not regressed.

LP: #1875400