Merge lp:~philpem/ubuntu/utopic/ptouch-driver/fix-for-1342979 into lp:ubuntu/vivid/ptouch-driver

[Phil Pemberton]

[Sebastien Bacher (seb128)]

Thanks. Do you plan to get that change in Debian as well? We are currently in sync and it would be better if we could keep things this way :-)

[Phil Pemberton (philpem)]

@Sebastien: I'd love to, but I haven't the faintest idea how!

I actually spent the long weekend fixing a lot of the bugs in the driver: https://bitbucket.org/philpem/printer-driver-ptouch/commits/all

It now works (or "can be configured to work"). Next thing I need to do is remove the "advance media" option; only "advance the tape at the end of the job" produces valid P-Touch print code.

I've tested the tip of the above Mercurial repository on a QL-500 (QL-series paper label printer, no auto cutter) and a PT-2450DX (PT-series "TZ Tape" 24mm plastic laminated tape label printer with auto cutter). It worked on both. Ideally the code needs testing on a P-touch QL printer with an auto cutter (a QL-550 or 560 would be good), but I can see no reason why it wouldn't work.

[Till Kamppeter (till-kamppeter)]

Looks OK for me.

By making a Ubuntu-only package for now and back-merge it into Debian later we can still get it into Vivid before Final Freeze.

review: Approve

[Phil Pemberton (philpem)]

This still doesn't get the driver working perfectly... other patches are needed (see my bitbucket) to generate valid control codes for QL series printers.

I'm putting the finishing touches on my changes and discussing trying to get those into Debian, which should get the driver into a usable state. If there's a definite preference to get these into Vivid ASAP, I can look at doing another merge request or a patch separate to that.

When is final freeze planned?

[Phil Pemberton (philpem)]

> This still doesn't get the driver working perfectly... other patches are
> needed (see my bitbucket) to generate valid control codes for QL series
> printers.

Substitute "QL and PT series printers". Looking back at my notes, the driver has problems with margins and paper feed, generating incorrect control codes.

[Till Kamppeter (till-kamppeter)]

OK, so I will not upload a new Ubuntu package yet.

Final Freeze is April 16, a week from now. If we do not get the full fix done by then we will make an SRU.

https://wiki.ubuntu.com/VividVervet/ReleaseSchedule

[Arnold Schrader (r3g3n58urg)]

Great, cutting is back now...

works properly with fix.

[Phil Pemberton (philpem)]

New merge request: https://code.launchpad.net/~philpem/ubuntu/utopic/ptouch-driver/ptouch-driver-fixup/+merge/255895

[Sebastien Bacher (seb128)]

it has been superseeded by the other change mentioned, closing as rejected then

review: Disapprove

Unmerged revisions

11. By Phil Pemberton on 2015-04-03

Fix the "ESC i A" (enable cutter) command patch to correctly send only on
printers which support it. (LP: #1342979)

=== modified file 'debian/changelog'
--- debian/changelog	2014-03-06 16:23:54 +0000
+++ debian/changelog	2015-04-03 21:03:26 +0000
@@ -1,3 +1,10 @@
+ptouch-driver (1.3-8ubuntu1) unstable; urgency=medium
+
+  * Fix the "ESC i A" (enable cutter) command patch to correctly send only on
+    printers which support it. (LP: #1342979)
+
+ -- Philip Pemberton <[e-mail]>  Fri, 03 Apr 2015 09:49:33 +0100
+
 ptouch-driver (1.3-8) unstable; urgency=medium
 
   [ Philip Pemberton ]

=== modified file 'debian/patches/send-esc-i-A-for-QL-only.patch'
--- debian/patches/send-esc-i-A-for-QL-only.patch	2014-03-06 16:23:54 +0000
+++ debian/patches/send-esc-i-A-for-QL-only.patch	2015-04-03 21:03:26 +0000
@@ -40,7 +40,7 @@
                            cut_media == CUPS_CUT_PAGE,
 -                          mirror == CUPS_TRUE);
 +                          mirror == CUPS_TRUE,
-+                          job_options->pixel_xfer == ULP);
++                          job_options->pixel_xfer);
    /* Set media and quality if label preamble is requested */
    unsigned page_size_y = new_page_options->page_size [1];
    unsigned image_height_px = lrint (page_size_y * vres / 72.0);

=== modified file 'rastertoptch.c'
--- rastertoptch.c	2014-03-06 16:23:54 +0000
+++ rastertoptch.c	2015-04-03 21:03:26 +0000
@@ -816,7 +816,7 @@
     emit_feed_cut_mirror (perform_feed == CUPS_ADVANCE_PAGE, feed,
                           cut_media == CUPS_CUT_PAGE,
                           mirror == CUPS_TRUE,
-                          job_options->pixel_xfer == ULP);
+                          job_options->pixel_xfer);
   /* Set media and quality if label preamble is requested */
   unsigned page_size_y = new_page_options->page_size [1];
   unsigned image_height_px = lrint (page_size_y * vres / 72.0);